build: correctly replace BUILD_SCM_HASH-PLACEHOLDER with BUILD_SCM_ABBREV_HASH
#30379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
angular-robot
bot
added
the
area: build & ci
devversion
approved these changes
May 23, 2025
…_ABBREV_HASH`
Correctly replace `BUILD_SCM_HASH-PLACEHOLDER` with `BUILD_SCM_ABBREV_HASH` by enclosing it in `{}` for proper interpolation.
Example of the issue: https://github.com/angular/angular-build-builds/blob/cac2e58892c99256d3a1f0abeb274f116edd5a26/package.json#L26
alan-agius4
force-pushed
the
BUILD_SCM_ABBREV_HASH
branch
from
11a5b3a to
8c422fc
Compare
|
The changes were merged into the following branches: main, 19.2.x, 20.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly replace
BUILD_SCM_HASH-PLACEHOLDERwithBUILD_SCM_ABBREV_HASHby enclosing it in{}for proper interpolation.Example of the issue: https://github.com/angular/angular-build-builds/blob/cac2e58892c99256d3a1f0abeb274f116edd5a26/package.json#L26