refactor(@angular/ssr): handle promise-like results from loadChildrenHelper
#31455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
…nHelper` The `loadChildrenHelper` function can return either an Observable or a Promise. This change ensures that we correctly handle both cases by checking if the return value is "thenable" before calling `.toPromise()`. This provides compatibility with different versions of Angular framework that have different return types for `loadChildren`. This is a temporary workaround and should be removed when Angular framework v21.0.0-next.7 is released.
alan-agius4
force-pushed
the
refactor-remove-to-promise
branch
from
64c74b4 to
14e9c0f
Compare
clydin
approved these changes
Oct 14, 2025
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
loadChildrenHelperfunction can return either an Observable or a Promise. This change ensures that we correctly handle both cases by checking if the return value is "thenable" before calling.toPromise().This provides compatibility with different versions of Angular framework that have different return types for
loadChildren.This is a temporary workaround and should be removed when Angular framework v21.0.0-next.7 is released.