fix(@angular/ssr): ensure server-side navigation triggers a redirect (Cherry-pick of #31497) #31501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: patch
alan-agius4
force-pushed
the
ssr-initial-nav
branch
from
cd2f423 to
9493e31
Compare
hybrist
approved these changes
Oct 16, 2025
alan-agius4
force-pushed
the
ssr-initial-nav
branch
6 times, most recently
from
f5b5d55 to
b1fbc88
Compare
alan-agius4
force-pushed
the
ssr-initial-nav
branch
from
b1fbc88 to
e27f01c
Compare
alan-agius4
force-pushed
the
ssr-initial-nav
branch
from
e27f01c to
ea63a60
Compare
When a navigation occurs on the server-side, such as using `router.navigate`, and the final URL is different from the initial URL that was requested, the server should respond with a redirect. Previously, the initial URL was being read from `router.lastSuccessfulNavigation.initialUrl`, which could be incorrect in scenarios involving server-side navigations, causing the comparison with the final URL to fail and preventing the redirect. This change ensures that the initial URL requested by the browser is used for the comparison, correctly triggering a redirect when necessary. Closes angular#31482 (cherry picked from commit 9c3a689)
alan-agius4
force-pushed
the
ssr-initial-nav
branch
from
ea63a60 to
eac2891
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #31497