Skip to content

fix(karma): add adapters to new reporter #31630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

fix(karma): add adapters to new reporter #31630

merged 1 commit into from
Oct 29, 2025

Conversation

@nicojs
Copy link
Contributor

@nicojs nicojs commented Oct 29, 2025 •
edited
Loading

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: fixes #31629

What is the new behavior?

Adhering to the karma reporter interface

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alan-agius4 alan-agius4 added the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Oct 29, 2025
@nicojs @alan-agius4
fix(@angular/build): add adapters to new reporter
20ca7a6 
This commit add `adapters` field to the `ProgressNotifierReporter`.

Closes angular#31629
@alan-agius4 alan-agius4 force-pushed the fix/karma-progress-reporter branch from d6f872b to 20ca7a6 Compare October 29, 2025 10:02
alan-agius4
alan-agius4 approved these changes Oct 29, 2025
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate area: @angular/build and removed merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release area: @angular/build labels Oct 29, 2025
@alan-agius4 alan-agius4 mentioned this pull request Oct 29, 2025
Merged
@clydin clydin merged commit 2cb04d5 into angular:main Oct 29, 2025
36 checks passed
@clydin
Copy link
Member

clydin commented Oct 29, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@nicojs nicojs deleted the fix/karma-progress-reporter branch October 29, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error on npx karma run since ProgressNotifierReporter

3 participants

@nicojs @clydin @alan-agius4