Skip to content

refactor(@angular-devkit/architect): correct misused promises lint failures #31678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

refactor(@angular-devkit/architect): correct misused promises lint failures #31678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions packages/angular_devkit/architect/testing/testing-architect-host.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export class TestingArchitectHost implements ArchitectHost {
const name = targetStringFromTarget(target);
const maybeTarget = this._targetMap.get(name);
if (!maybeTarget) {
return this._backendHost && this._backendHost.getBuilderNameForTarget(target);
return this._backendHost?.getBuilderNameForTarget(target) ?? null;
}

return maybeTarget.builderName;
Expand All @@ -87,8 +87,7 @@ export class TestingArchitectHost implements ArchitectHost {
*/
async resolveBuilder(builderName: string): Promise<BuilderInfo | null> {
return (
this._builderMap.get(builderName) ||
(this._backendHost && this._backendHost.resolveBuilder(builderName))
this._builderMap.get(builderName) || (this._backendHost?.resolveBuilder(builderName) ?? null)
);
}

Expand All @@ -103,20 +102,19 @@ export class TestingArchitectHost implements ArchitectHost {
const name = targetStringFromTarget(target);
const maybeTarget = this._targetMap.get(name);
if (!maybeTarget) {
return this._backendHost && this._backendHost.getOptionsForTarget(target);
return this._backendHost?.getOptionsForTarget(target) ?? null;
}

return maybeTarget.options;
}

async getProjectMetadata(target: Target | string): Promise<json.JsonObject | null> {
return this._backendHost && this._backendHost.getProjectMetadata(target as string);
return this._backendHost?.getProjectMetadata(target as string) ?? null;
}

async loadBuilder(info: BuilderInfo): Promise<Builder | null> {
return (
this._builderImportMap.get(info.builderName) ||
(this._backendHost && this._backendHost.loadBuilder(info))
this._builderImportMap.get(info.builderName) || (this._backendHost?.loadBuilder(info) ?? null)
);
}
}