fix(@angular/build): ensure TestBed setup is robust in non-isolated Vitest #31731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
added
the
action: review
Contributor
🚀 awesome! Thanks Charles! |
1 task
…itest
This commit refines the Angular TestBed initialization within the Vitest runner to ensure correct behavior in non-isolated test environments (`isolate: false`).
Previously, in a non-isolated setup, the TestBed initialization logic in the virtual setup file could be problematic if the file was evaluated multiple times. This could lead to re-registering `beforeEach`/`afterEach` hooks or attempting to re-initialize the TestBed, causing errors or unexpected test behavior.
This change introduces a globally unique symbol guard (`Symbol.for('@angular/cli/testbed-setup')`) that ensures the entire TestBed setup block (including hook registration and `initTestEnvironment`) is executed only once per test run. This prevents redundant executions and potential errors.
Finally, the `isolate` option in Vitest is now explicitly defaulted to `false` when not specified by the user, aligning with the traditional Karma/Jasmine experience.
clydin
force-pushed
the
unit-test/vitest-config-merging
branch
from
1a13e11 to
3d7f8ab
Compare
1 task
alan-agius4
approved these changes
Nov 10, 2025
alan-agius4
added
action: merge
Collaborator
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refines the Angular TestBed initialization within the Vitest runner to ensure correct behavior in non-isolated test environments (
isolate: false).Previously, in a non-isolated setup, the TestBed initialization logic in the virtual setup file could be problematic if the file was evaluated multiple times. This could lead to re-registering
beforeEach/afterEachhooks or attempting to re-initialize the TestBed, causing errors or unexpected test behavior.This change introduces a globally unique symbol guard (
Symbol.for('@angular/cli/testbed-setup')) that ensures the entire TestBed setup block (including hook registration andinitTestEnvironment) is executed only once per test run. This prevents redundant executions and potential errors.Finally, the
isolateoption in Vitest is now explicitly defaulted tofalsewhen not specified by the user, aligning with the traditional Karma/Jasmine experience.