Skip to content

fix(@angular/build): enhance Vitest dependency externalization and pre-bundling #31781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
Merged

fix(@angular/build): enhance Vitest dependency externalization and pre-bundling #31781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 7 additions & 20 deletions packages/angular/build/src/builders/unit-test/runners/vitest/build-options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,6 @@ import { NormalizedUnitTestBuilderOptions, injectTestingPolyfills } from '../../
import { findTests, getTestEntrypoints } from '../../test-discovery';
import { RunnerOptions } from '../api';

/**
* A list of Angular related packages that should be marked as external.
* This allows Vite to pre-bundle them, improving performance.
*/
const ANGULAR_PACKAGES_TO_EXTERNALIZE = [
'@angular/core',
'@angular/common',
'@angular/platform-browser',
'@angular/compiler',
'@angular/router',
'@angular/forms',
'@angular/animations',
'rxjs',
];

function createTestBedInitVirtualFile(
providersFile: string | undefined,
projectSourceRoot: string,
Expand Down Expand Up @@ -110,11 +95,10 @@ export async function getVitestBuildOptions(
});
entryPoints.set('init-testbed', 'angular:test-bed-init');

const externalDependencies = new Set(['vitest']);
ANGULAR_PACKAGES_TO_EXTERNALIZE.forEach((dep) => externalDependencies.add(dep));

// The 'vitest' package is always external for testing purposes
const externalDependencies = ['vitest'];
if (baseBuildOptions.externalDependencies) {
baseBuildOptions.externalDependencies.forEach((dep) => externalDependencies.add(dep));
externalDependencies.push(...baseBuildOptions.externalDependencies);
}

const buildOptions: Partial<ApplicationBuilderInternalOptions> = {
Expand All @@ -135,7 +119,10 @@ export async function getVitestBuildOptions(
outputHashing: adjustOutputHashing(baseBuildOptions.outputHashing),
optimization: false,
entryPoints,
externalDependencies: [...externalDependencies],
// Enable support for vitest browser prebundling. Excludes can be controlled with a runnerConfig
// and the `optimizeDeps.exclude` option.
externalPackages: true,
externalDependencies,
};

buildOptions.polyfills = injectTestingPolyfills(buildOptions.polyfills);
Expand Down
2 changes: 1 addition & 1 deletion packages/angular/build/src/builders/unit-test/runners/vitest/executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ export class VitestExecutor implements TestExecutor {
coverage,
projectName,
projectSourceRoot: this.options.projectSourceRoot,
optimizeDepsInclude: this.externalMetadata.explicitBrowser,
optimizeDepsInclude: this.externalMetadata.implicitBrowser,
reporters,
setupFiles: testSetupFiles,
projectPlugins,
Expand Down