Skip to content

fix(@angular/build): ensure ɵgetOrCreateAngularServerApp is always defined after errors [patch] #31798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
Merged

fix(@angular/build): ensure ɵgetOrCreateAngularServerApp is always defined after errors [patch] #31798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/angular/build/src/builders/dev-server/vite-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,9 +598,12 @@ async function invalidateUpdatedFiles(
}

if (serverApplicationChanged) {
// Clear the server app cache and
// trigger module evaluation before reload to initiate dependency optimization.
const { ɵdestroyAngularServerApp } = (await server.ssrLoadModule('/main.server.mjs')) as {
// Clear the server app cache and trigger module evaluation before reload to initiate dependency optimization.
// The querystring is needed as a workaround for:
// `ɵgetOrCreateAngularServerApp` can be undefined right after an error.
const { ɵdestroyAngularServerApp } = (await server.ssrLoadModule(
`/main.server.mjs?timestamp=${Date.now()}`,
)) as {
ɵdestroyAngularServerApp: typeof destroyAngularServerApp;
};

Expand Down
6 changes: 0 additions & 6 deletions packages/angular/build/src/tools/vite/middlewares/ssr-middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,6 @@ export function createAngularSsrInternalMiddleware(
ɵgetOrCreateAngularServerApp: typeof getOrCreateAngularServerApp;
};

// `ɵgetOrCreateAngularServerApp` can be undefined right after an error.
// See: https://github.com/angular/angular-cli/issues/29907
if (!ɵgetOrCreateAngularServerApp) {
return next();
}

const angularServerApp = ɵgetOrCreateAngularServerApp({
allowStaticRouteRender: true,
});
Expand Down