Skip to content

Conversation

@pawelfras
Copy link
Contributor

@pawelfras pawelfras commented Nov 16, 2025

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #31830

What is the new behavior?

This PR introduces fixes for apps created with flag --file-name-style-guide=2016:

  • fixes references to non-existing app.ts file, causing build and test issues
  • changes file names from app-module.ts and app-routing-module.ts to app.module.ts and app-routing.module.ts, for consistency

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pawelfras pawelfras changed the title File name style guide fixes fix(@schematics/angular): issues in apps generated with '--file-name-style-guide=2016' flag Nov 16, 2025
…style-guide=2016' flag

- fixes references to non-existing `app.ts` file, causing build and test issues
- changes file names from `app-module.ts` and `app-routing-module.ts` to `app.module.ts` and `app-routing.module.ts`, for consistency.

Closes: angular#31830
@alan-agius4 alan-agius4 force-pushed the file-name-style-guide-fixes branch from d0644c5 to 52f788d Compare November 17, 2025 08:27
@alan-agius4 alan-agius4 added target: rc This PR is targeted for the next release-candidate and removed area: @angular/cli labels Nov 17, 2025
@alan-agius4 alan-agius4 linked an issue Nov 17, 2025 that may be closed by this pull request
1 task
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Nov 17, 2025
@angular-robot angular-robot bot requested a review from alan-agius4 November 17, 2025 12:55
@pawelfras
Copy link
Contributor Author

pawelfras commented Nov 17, 2025

Hi @alan-agius4,
I just noticed that the main.ts imported a non-existent app-module.ts file. I added changes to the main.ts.template file to make it use the typeSeparator variable as well. Would you mind taking a look at this change?
Thank you!

@alan-agius4
Copy link
Collaborator

@pawelfras, sure thanks.

@dgp1130 dgp1130 merged commit 70e67fe into angular:main Nov 17, 2025
31 checks passed
@dgp1130
Copy link
Collaborator

dgp1130 commented Nov 17, 2025

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues in apps generated with --file-name-style-guide=2016 flag

3 participants