-
Notifications
You must be signed in to change notification settings - Fork 11.9k
ng build for i18n - set document locale #8102
Copy link
Copy link
Closed
Labels
P5The team acknowledges the request but does not plan to address it, it remains open for discussionThe team acknowledges the request but does not plan to address it, it remains open for discussionarea: @angular-devkit/build-angularfeatureLabel used to distinguish feature request from other issuesLabel used to distinguish feature request from other issueshelp wantedLabel noting an issue which the team is looking for contribution from the community to fixLabel noting an issue which the team is looking for contribution from the community to fix
Milestone
Description
Metadata
Metadata
Assignees
Labels
P5The team acknowledges the request but does not plan to address it, it remains open for discussionThe team acknowledges the request but does not plan to address it, it remains open for discussionarea: @angular-devkit/build-angularfeatureLabel used to distinguish feature request from other issuesLabel used to distinguish feature request from other issueshelp wantedLabel noting an issue which the team is looking for contribution from the community to fixLabel noting an issue which the team is looking for contribution from the community to fix
Bug Report or Feature Request (mark with an
x)Versions.
@angular/cli: 1.4.4
node: 8.5.0
os: win32 x64
@angular/animations: 4.4.4
@angular/cdk: 2.0.0-beta.12
@angular/common: 4.4.4
@angular/compiler: 4.4.4
@angular/core: 4.4.4
@angular/forms: 4.4.4
@angular/http: 4.4.4
@angular/material: 2.0.0-beta.12
@angular/platform-browser: 4.4.4
@angular/platform-browser-dynamic: 4.4.4
@angular/router: 4.4.4
@angular/cli: 1.4.4
@angular/compiler-cli: 4.4.4
@angular/language-service: 4.4.4
typescript: 2.3.4
Repro steps.
Run a i18n build including the locale flag:
Then have a look at the index.html inside dist folder.
The document's locale is still set to
<html lang="en">when you build a locale "de".This causes some browsers to suggest a translated version of the site and breaks built in spellcheckers.
The log given by the failure.
No log
Desired functionality.
The index.html in build results should contain a correct lang attribute.
Mention any other details that might be useful.
Nothing