Skip to content
This repository was archived by the owner on Mar 20, 2024. It is now read-only.

Trans(tutorial/toh-pt2.jade)#18

Merged
byungjune merged 2 commits intoangular:masterfrom
tiratano:master
Jan 6, 2017
Merged

Trans(tutorial/toh-pt2.jade)#18
byungjune merged 2 commits intoangular:masterfrom
tiratano:master

Conversation

@tiratano
Copy link
Contributor

@tiratano tiratano commented Jan 5, 2017

튜토리얼2 번역

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@tiratano
Copy link
Contributor Author

tiratano commented Jan 5, 2017

I signed a CLA!

@googlebot
Copy link

CLAs look good, thanks!


Run the <live-example></live-example> for this part.

잠시 히어로의 목록을 보여주기 위해 필요한 것을 살펴봅시다. 먼저, 히어로들의 정보가 필요합니다. 우리는 이 히어로들을 뷰의 템플릿에 보여주길 원하고, 이것을 어떻게 하는지 살펴보겠습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiratano 올려주신 PR 확인하였습니다.
실제 코드를 실행했을 때 차이가 없지만, script의 가독성을 위해 한글번역본도 원문과 같이 줄바꿈을 해주면 어떨까요?

[예시]

변경전 :

  • 잠시 히어로의 목록을 보여주기 위해 필요한 것을 살펴봅시다. 먼저, 히어로들의 정보가 필요합니다.

변경후 :

  • 잠시 히어로의 목록을 보여주기 위해 필요한 것을 살펴봅시다.
  • 먼저, 히어로들의 정보가 필요합니다.

@byungjune byungjune merged commit 6cf996d into angular:master Jan 6, 2017
@tiratano
Copy link
Contributor Author

tiratano commented Jan 6, 2017

원본과 동일하게 줄바꿈처리 했습니다.

byungjune added a commit to byungjune/angular-ko that referenced this pull request Jan 8, 2017
Trans(tutorial/toh-pt2.jade) - Reveiw Completed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants