This repository was archived by the owner on Mar 20, 2024. It is now read-only.
Trans(tutorial/toh-pt2.jade)#18
Merged
byungjune merged 2 commits intoangular:masterfrom Jan 6, 2017
tiratano:master
Merged
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Contributor
Author
|
I signed a CLA! |
|
CLAs look good, thanks! |
byungjune
reviewed
Jan 5, 2017
|
|
||
| Run the <live-example></live-example> for this part. | ||
|
|
||
| 잠시 히어로의 목록을 보여주기 위해 필요한 것을 살펴봅시다. 먼저, 히어로들의 정보가 필요합니다. 우리는 이 히어로들을 뷰의 템플릿에 보여주길 원하고, 이것을 어떻게 하는지 살펴보겠습니다. |
Contributor
There was a problem hiding this comment.
@tiratano 올려주신 PR 확인하였습니다.
실제 코드를 실행했을 때 차이가 없지만, script의 가독성을 위해 한글번역본도 원문과 같이 줄바꿈을 해주면 어떨까요?
[예시]
변경전 :
- 잠시 히어로의 목록을 보여주기 위해 필요한 것을 살펴봅시다. 먼저, 히어로들의 정보가 필요합니다.
변경후 :
- 잠시 히어로의 목록을 보여주기 위해 필요한 것을 살펴봅시다.
- 먼저, 히어로들의 정보가 필요합니다.
Contributor
Author
|
원본과 동일하게 줄바꿈처리 했습니다. |
byungjune
added a commit
to byungjune/angular-ko
that referenced
this pull request
Jan 8, 2017
Trans(tutorial/toh-pt2.jade) - Reveiw Completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
튜토리얼2 번역