Skip to content
This repository was archived by the owner on Mar 20, 2024. It is now read-only.

Trans(guide/animations.jade), Trans(guide/cheatsheet.jade), Trans(cookbook/_data.json), Trans(glossary.jade)#35

Merged
byungjune merged 5 commits intoangular:masterfrom
tiratano:master
Mar 5, 2017
Merged

Trans(guide/animations.jade), Trans(guide/cheatsheet.jade), Trans(cookbook/_data.json), Trans(glossary.jade)#35
byungjune merged 5 commits intoangular:masterfrom
tiratano:master

Conversation

@tiratano
Copy link
Contributor

@tiratano tiratano commented Mar 4, 2017

cheatsheet-ko.json include 부분이 누락되어
Trans(guide/cheatsheet.jade) 도 추가했습니다.

cookbook/_data.json에서 메뉴명이 길어서 두줄로 보이는 것이 있어서 한줄로 보이도록 수정했습니다.
"AngularJS에서 Angular로의 빠른 참조" => "AngularJS에서 Angular로 전환"

glossary.jade에서 일부 용어를 수정했습니다.
production apps: "생산용 앱" => "상용 앱"

Copy link
Contributor

@byungjune byungjune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰하였습니다 : )
수고하셨습니다 👍

include ../_util-fns

:marked
모션은 모던 웹 어플리케이션의 디자인에서 중요한 부분입니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역의 통일성을 위해 application의 한글표기를 "애플리케이션"으로 바꾸면 좋을 것 같습니다 : )

  • 변경전 : 어플리케이션
  • 변경후 : 애플리케이션

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하겠습니다. ^^;



:marked
### `void '상태
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

따옴표의 변경이 필요합니다 : )
변경전 : ### void '상태 변경후 : ### void` 상태

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하겠습니다.


If you don't provide a unit when specifying dimension, Angular assumes the default of `px`:

* `50`은 '50px'와 동일합니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50px의 가 누락되었습니다. 변경전 : *50은 '50px'와 동일합니다. 변경후 : * 50'50px'`와 동일합니다.


* `'50px'`
* `'3em'`
* `'100%'`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 보기를 반복해서 작성해야 한/영 화면에서 볼 수 있습니다.
변경전 :

  • '50px'
  • '3em'
  • '100%'

변경후 :

  • '50px'
  • '50px'
  • '3em'
  • '3em'
  • '100%'
  • '100%'

Copy link
Contributor Author

@tiratano tiratano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 감사합니다. 👍
수정 반영했습니다~

include ../_util-fns

:marked
모션은 모던 웹 어플리케이션의 디자인에서 중요한 부분입니다.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하겠습니다. ^^;



:marked
### `void '상태
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하겠습니다.

- cheatsheet-ko.json include
@tiratano
Copy link
Contributor Author

tiratano commented Mar 5, 2017

cheatsheet-ko.json include 부분이 누락되어
Trans(guide/cheatsheet.jade) 도 추가했습니다.

@tiratano tiratano changed the title Trans(guide/animations.jade) Trans(guide/animations.jade), Trans(guide/cheatsheet.jade) Mar 5, 2017
- 메뉴에 한줄로 보이도록 메뉴명 수정 (AngularJS에서 Angular로의 빠른 참조 => AngularJS에서 Angular로 전환)
@tiratano tiratano changed the title Trans(guide/animations.jade), Trans(guide/cheatsheet.jade) Trans(guide/animations.jade), Trans(guide/cheatsheet.jade), Trans(cookbook/_data.json) Mar 5, 2017
- production app 번역 수정: "생산용 앱" => "상용 앱"
@tiratano tiratano changed the title Trans(guide/animations.jade), Trans(guide/cheatsheet.jade), Trans(cookbook/_data.json) Trans(guide/animations.jade), Trans(guide/cheatsheet.jade), Trans(cookbook/_data.json), Trans(glossary.jade) Mar 5, 2017
@byungjune byungjune merged commit 97d81e7 into angular:master Mar 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants