This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(dart): cleanup 'live example' links#1449
Merged
kwalrath merged 2 commits intoangular:masterfrom May 20, 2016
Merged
Conversation
This fixes various issues such as: - missing space in Dart version between the live demo and demo source links. - Live example link directing to Plunker for Dart. The main mixins (`liveExampleLink`*) used to support the generation of links now assume reasonable default values for their arguments, and in most cases the defaults are used.
Contributor
Author
|
@kwalrath : this impacts mainly the generated Dart docs (the TS docs will be essentially the same). |
Contributor
|
I'll take a look. @wardbell, do you also want to review this? |
Contributor
|
Nah. Go for it! |
As agree to with @kwalrath.
Contributor
|
LGTM! I'll squash and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes various issues such as:
The main mixins (
liveExampleLinkandliveExampleLink2) used to support the generation of links now assume reasonable default values for their arguments, and in most cases the defaults are used.