This repository was archived by the owner on Dec 4, 2017. It is now read-only.
Fix typo (repeated file names) #3286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/cc @kapunahelewong |
Contributor
kapunahelewong
left a comment
kapunahelewong
left a comment
There was a problem hiding this comment.
Thank you! You have a good eye. :)
| [source code displayed below](#source-code "Reactive Forms source code"). | ||
| Notice that `hero-list.component.ts` and `hero-list.component.ts` | ||
| Notice that `hero-list.component.ts` and `hero.service.ts` | ||
| import `Observable` and `finally` from `rxjs`. |
Contributor
There was a problem hiding this comment.
This is a great catch, @AlexanderLukin! I was looking closely at the example files and noticed something though. How about this (or something like it):
Notice that
hero-list.component.tsimportsObservableandfinallywhilehero.service.tsimportsObservable,of, anddelayfromrxjs.
Contributor
Author
There was a problem hiding this comment.
Yes, I think you've proposed the most accurate version. I've corrected my PR in accordance with your changes.
Correct subparagraph in accordance with @kapunahelewong suggestion. Add separate info about imports from `rxjs` lib for `hero-list.component.ts` and `hero.service.ts`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.