1.2.0: An event that triggers another event causes $apply already in progress error

[ryanzec]

Here is the plunker:

http://plnkr.co/edit/aiNK9bAP6BYnYEBMNle4?p=preview
http://plnkr.co/edit/AuhbiPD4kriFTxH17hyL?p=preview updated to use directive

This is a simplified version of my auto focus directive (I know accessing the DOM in the controller is a no no) but am using this to show the issue. The ng-click event triggers a focus event on the input which has a ng-focus attached. When doing this, it causes a $apply already in progress error.

Is this a bug or am I not supposed to be able to do this?

[ryanzec]

I believe modifying this code for the event directives:

scope.$apply(function() {
  fn(scope, {$event:event});
});

to this:

if(scope.$root.$$phase) {
  fn(scope, {$event:event});
} else {
  scope.$apply(function() {
    fn(scope, {$event:event});
  });
}

will fix the issue without breaking anything. I would be more than happy to submit a pull request if I can get some verification that this would be a welcomed change.

[ryanzec]

Any updated on this? Can someone at least verify whether or not this is a bug, working as intended, or I am doing something wrong in my code?

[btford]

setting focus synchronously in the controller is problematic. You should write your own directive for this (looks like you already have: https://github.com/nucleus-angular/auto-focus ).

[ryanzec]

@btford: The thing is, I get this error when using that directive you mentioned. Are there any issues with the suggested change I made?

[ryanzec]

Could I get some explanation on why this is working as expected (why can't one event trigger another event?) and why my change suggestion would be bad?

Also here is another example where I move the the setting focus to a directive and out of the controller:

http://plnkr.co/edit/AuhbiPD4kriFTxH17hyL?p=preview

[scamden]

i also see this issue. calling focus on an element can cause the event to fire synchronously. if that focus was called within a digest loop (which almost every action in angular is) it causes an exception. seems like the clear answer is to wrap angular's ng-blur and ng-focus directives in a safe apply, since the browser behavior is unique for them. my2¢

[bluishoul]

@scamden I used a setTimeout(callback, 0) to avoid the digest loop....