-
Notifications
You must be signed in to change notification settings - Fork 27.3k
Bugfix - Typos #13507
Bugfix - Typos #13507
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
.travis.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There' also instal -> install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, missed this one!
e0bdaa5 to
99a154d
Compare
|
Amended to include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe zegative means zero or negative 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But from what I understand, zero values are being set to null, right? So in that case zero is not allowed 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but it could be a bug in the code and not a typo in the docs 😛
Just kidding...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, that would be bad
|
Nice one ! I favour (pun intended) |
Yeah, but given that this project is |
|
BTW this is not "backportable" to Thx for all the typo crashing so far 👍 |
This PR fixes few typo found around the place