fix(copy): add support for String/Boolean/Number object types

[jbedard]

By modifying isString/isBoolean/isNumber this also effects everywhere those are used, which I think is good? But could also effect performance in those areas if called an extreme number of times.

Fixes the original issue mentioned in #13398

[lgalfaso]

I am not sure about this PR change to isXXX can we refactor this so
toString is called once on the object?

On Monday, December 28, 2015, Jason Bedard notifications@github.com wrote:

By modifying isString/isBoolean/isNumber this also effects everywhere
those are used, which I think is good? But could also effect performance in
those areas if called an extreme number of times.

Fixes the original issue mentioned in #13398

#13398

You can view, comment on, or merge this pull request online at:

#13641
Commit Summary

• fix(copy): add support for String/Boolean/Number object types

File Changes

• M src/Angular.js
  https://github.com/angular/angular.js/pull/13641/files#diff-0 (10)
• M test/AngularSpec.js
  https://github.com/angular/angular.js/pull/13641/files#diff-1 (24)

Patch Links:

• https://github.com/angular/angular.js/pull/13641.patch
• https://github.com/angular/angular.js/pull/13641.diff

—
Reply to this email directly or view it on GitHub
#13641.

[jbedard]

I've updated the PR to only make the toString call once.

Original commit for reference: 5dc679d

[lgalfaso]

I think this will not work as intended with new Boolean(false) nor with new String('')

[jbedard]

Updated again

[lgalfaso]

LGTM