This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(guide/migration): add notes for migrating from 1.4 to 1.5#13808
Closed
gkalpak wants to merge 3 commits intoangular:masterfrom
Closed
docs(guide/migration): add notes for migrating from 1.4 to 1.5#13808gkalpak wants to merge 3 commits intoangular:masterfrom
gkalpak wants to merge 3 commits intoangular:masterfrom
Conversation
Member
Author
|
Do you think it needs more (any) code examples ? The changes sounded straightforward enough to me to warrant code examples, but all previous migration notes are full of code 😕 |
4a05ec2 to
5e1d603
Compare
Contributor
There was a problem hiding this comment.
It might be helpful to the reader to quickly enumerate some of the things that are array-like, such as strings and DOM nodes, at this point so that they can be reassured.
Contributor
|
A couple of minor comments. But generally looks good. |
docs/content/guide/migration.ngdoc
Outdated
Contributor
There was a problem hiding this comment.
could be shortened to .. a big step towards preparing developers for a smoother ..
Member
Author
|
Merged. Thx @petebacondarwin and @Narretz for the reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13474
A few notes:
1.5.0-rc.1are not included (yet).