This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(angularFiles): add missing files#14314
Closed
Narretz wants to merge 1 commit intoangular:masterfrom
Closed
Conversation
ngMessageFormat test files were missing from angularTest ngMessages and ngAnimate were missing from karmaModules. The test files were using two APIs that are not exposed in the module tests. jqLiteHasClass has been changed to use angular.element(..).hasClass() instead, and for ngMessagesSpec a trim() fn has been added
| var classes = clazz.trim().split(/\s+/); | ||
| for (var i = 0; i < classes.length; ++i) { | ||
| if (!jqLiteHasClass(actual[0], classes[i])) { | ||
| if (!angular.element(actual[0]).hasClass(classes[i])) { |
Contributor
Author
There was a problem hiding this comment.
I guess this is a bit heavier than calling jqLiteHasClass directly, so it might make the tests run slower.
Member
There was a problem hiding this comment.
It seems that actual is already a jqLite/jQuery element. We could probably do actual.hasClass()
Contributor
Author
There was a problem hiding this comment.
Doesn't the identity of atual depend on what is passed to expect?
Member
There was a problem hiding this comment.
Yes. actual is what we pass to expect.
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
May 25, 2016
ngMessageFormat test files were missing from angularTest ngMessages and ngAnimate were missing from karmaModules. This change highlighted a number of problems in the tests and code, which are also fixed. Closes angular#14314
3 tasks
petebacondarwin
added a commit
to petebacondarwin/angular.js
that referenced
this pull request
May 25, 2016
ngMessageFormat test files were missing from angularTest ngMessages and ngAnimate were missing from karmaModules. This change highlighted a number of problems in the tests and code, which are also fixed. Closes angular#14314
petebacondarwin
added a commit
to petebacondarwin/angular.js
that referenced
this pull request
May 25, 2016
ngMessageFormat test files were missing from angularTest ngMessages and ngAnimate were missing from karmaModules. This change highlighted a number of problems in the tests and code, which are now fixed. Closes angular#14314
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ngMessageFormat test files were missing from angularTest
ngMessages and ngAnimate were missing from karmaModules. The test
files were using two APIs that are not exposed in the module tests.
jqLiteHasClass has been changed to use angular.element(..).hasClass()
instead, and for ngMessagesSpec a trim() fn has been added