Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/External Resources): Added a course#15075

Closed
packtpartner wants to merge 1 commit intoangular:masterfrom
packtpartner:patch-2
Closed

docs(guide/External Resources): Added a course#15075
packtpartner wants to merge 1 commit intoangular:masterfrom
packtpartner:patch-2

Conversation

@packtpartner
Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

feature

What is the current behavior? (You can also link to an open issue here)

linked to course

What is the new behavior (if this is a feature change)?

linked to course

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

Other information:

Added a new course under Paid Onsite

Added a new course under Paid Onsite
@petebacondarwin
Copy link
Copy Markdown
Contributor

This course is actually "paid online" not "paid onsite". But I will fix up and merge.

@packtpartner
Copy link
Copy Markdown
Contributor Author

packtpartner commented Sep 2, 2016

Sorry for my ignorance. Thanks @petebacondarwin
Do I need to put in a pull request again?

@gkalpak
Copy link
Copy Markdown
Member

gkalpak commented Sep 7, 2016

@packtpartner, @petebacondarwin fixed that while merging - you don't need to do anything 😄

@packtpartner
Copy link
Copy Markdown
Contributor Author

@gkalpak thanks a lot. Will it show on https://docs.angularjs.org/guide/external-resources anytime soon?

@gkalpak
Copy link
Copy Markdown
Member

gkalpak commented Sep 8, 2016

@packtpartner, it should be visible already.

@petebacondarwin
Copy link
Copy Markdown
Contributor

It is now that our CI server got back up and running

@packtpartner
Copy link
Copy Markdown
Contributor Author

Sorry for the trouble, but I am still unable to see it featured on https://docs.angularjs.org/guide/external-resources @petebacondarwin @gkalpak

@gkalpak
Copy link
Copy Markdown
Member

gkalpak commented Sep 9, 2016

Hm...it is listed (as Packt) under Courses > Paid online. (You had originally added it under Courses > Paid on-site).

But looking at it, it looks morw like a book, right?

@petebacondarwin
Copy link
Copy Markdown
Contributor

It is an online course.

@petebacondarwin
Copy link
Copy Markdown
Contributor

It is just packaged as an ebook

@packtpartner
Copy link
Copy Markdown
Contributor Author

Thanks for all your help @petebacondarwin @gkalpak :)

petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants