docs(angular.forEach): key value reversed in the example code#15384
docs(angular.forEach): key value reversed in the example code#15384TruthReveller wants to merge 1 commit intoangular:masterfrom
Conversation
var values = {name: 'misko', gender: 'male'};
var log = [];
angular.forEach(values, function(value, key) {
this.push(key + ': ' + value);
}, log);
expect(log).toEqual(['name: misko', 'gender: male']);
should be
angular.forEach(values, function(key, value) {
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
|
what happens when Travis CI build fails? |
|
If Travis fails when only documentation is changed, then it's usually not a problem with the PR itself. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Update error in docs
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information:
should be
angular.forEach(values, function(key, value) {