This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($location): fix back-button not triggering $locationChangeStart#2204
Closed
quazzie wants to merge 1 commit intoangular:masterfrom
quazzie:backbutton-locationchangestart
Closed
fix($location): fix back-button not triggering $locationChangeStart#2204quazzie wants to merge 1 commit intoangular:masterfrom quazzie:backbutton-locationchangestart
quazzie wants to merge 1 commit intoangular:masterfrom
quazzie:backbutton-locationchangestart
Conversation
$locationChangeStart does not get broadcasted when pressing the back-button. Closes #2109
Contributor
|
@quazzie what's the status on this, why did you close the PR? |
Contributor
|
Oh you opened #2206, got it. |
Contributor
Author
|
hehe closed it because im a git newbie :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$locationChangeStart does not get broadcasted when pressing the back-button.
bug example : http://plnkr.co/edit/NycOKi?p=preview
Closes #2109