2.1.x #14164

SteveHu20 · 2017-01-28T07:33:45Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

This benchmark tracks the generated file size for large forms as well as the time to create and destroy many form fields.

originally cherry-picked from 445e592

All of `@angular/compiler` is private, so we can export everything we need directly.

- for now only wraps the `@Input` properties and calls to `ngOnInit`, `ngDoCheck` and `ngOnChanges` of directives. - also groups eval sources by NgModule. Part of angular#11683

…utes Closes angular#12183

…ed after NavigationCancel

…dModules are set (angular#11742)

…given (angular#11797)

…pressions (angular#12396) Fixes angular#12004 Closes angular#12071

I put an extractor into your extract so you can extract while you extract. This allows integrators to call Extractor as a library. Also refactors Extractor a bit so that callers need fewer arguments or arguments that are at the right semantic level. The refactoring causes no function change.

fixes angular#11889 fixes angular#12428

See The Angular Style Guide, [Section 2.2 - Separate File Names with Dots and Dashes](https://angular.io/docs/ts/latest/guide/style-guide.html#!#02-02)

…y a module

… routes Closes angular#12375

…for aux routes Closes angular#11345

Closes angular#11208, angular#11082

…ng from a componentless routes

…uivalent

Closes angular#7067

Closes angular#12583

This is important so that we don’t generate things multiple times.

They are replaced by generated visitor functions `view.visitRootNodes` / `view.visitProjectableNodes`.

Closes angular#12592

googlebot · 2017-01-28T07:34:11Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

IgorMinar · 2017-01-28T08:22:21Z

hi there. I'm not sure what you are trying to do, but this PR is not right. I'm going to close it.

You can read instructions on how to send us PRs here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md

angular-automatic-lock-bot · 2019-09-10T16:22:28Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

tbosch and others added 30 commits October 20, 2016 14:47

fix(benchmarks): fix method name in targetable spec

9223066

feat(benchmark): add large form benchmark

31150fe

This benchmark tracks the generated file size for large forms as well as the time to create and destroy many form fields.

chore(ci): make browserstack tests optional until they are fixed

1045504

refactor(forms): remove ListWrapper facades

ea186d5

originally cherry-picked from 445e592

refactor: remove some facades (angular#12335)

680ceb7

chore(tslint.json): semicolon rule expects an array

50b524b

chore(ci): re-enable browserstack tests in ci

f1b5ba9

refactor(compiler): remove private exports

c04b4d7

All of `@angular/compiler` is private, so we can export everything we need directly.

refactor(compiler): don’t use the OfflineCompiler in extract_i18n

4ba8f19

refactor(compiler): introduce directive wrappers to generate less code

958bb0d

- for now only wraps the `@Input` properties and calls to `ngOnInit`, `ngDoCheck` and `ngOnChanges` of directives. - also groups eval sources by NgModule. Part of angular#11683

fix(router): fix lazy loading triggered by redirects from wildcard ro…

20b4617

…utes Closes angular#12183

cleanup(router): add a test verifying than NavigationEnd is not emitt…

2598b59

…ed after NavigationCancel

fix(router): module loader should start compiling modules when stubbe…

a2d4299

…dModules are set (angular#11742)

fix(router): do not update primary route if only secondary outlet is …

dd08d42

…given (angular#11797)

chore(release): cut the 2.2.0-beta.0 release and add changelog

79f1798

docs(changelog): add 2.1.1 changelog

3dffbb6

chore(release): cut the 2.1.1 release

7a1f964

fix(compiler): don't access view local variables nor pipes in host ex…

7bce015

…pressions (angular#12396) Fixes angular#12004 Closes angular#12071

docs(changelog): fix minor typo (angular#12429)

767841b

refactor: remove most facades (angular#12399)

675e3d4

fix(compiler): walk third party modules (angular#12453)

0fd859c

fixes angular#11889 fixes angular#12428

doc(compiler-cli): align example with style guide (angular#12414)

fddf30c

See The Angular Style Guide, [Section 2.2 - Separate File Names with Dots and Dashes](https://angular.io/docs/ts/latest/guide/style-guide.html#!#02-02)

docs(common): minor corrections/improvements for NgClass (angular#12327)

93854e0

fix(CompilerCli): assert that all pipes and directives are declared b…

8113a03

…y a module

fix(router): canDeactivate guards are not triggered for componentless…

089d453

… routes Closes angular#12375

fix(router): add a test to make sure canDeactivate guards are called …

8c6b376

…for aux routes Closes angular#11345

fix(router): disallow component routes with named outlets

2c30365

Closes angular#11208, angular#11082

fix(router): change router not to deactivate aux routes when navigati…

3b5fc56

…ng from a componentless routes

tests(router): add a test showing how to handle resovle errors

07c44a7

alfaproject and others added 24 commits November 3, 2016 10:29

chore(package): remove unused lodash and sorted-object

9f65684

chore(lint): deduplicate tslint dependency

fae2316

chore(lint): replace enforce-copyright-header rule with the native eq…

e6a5dc9

…uivalent

fix(core): improve error when multiple components match the same element

dbd9147

Closes angular#7067

chore(lint): extend linting to all modules and tools

3c28aee

style: add missing copyright headers

927fb04

style: add missing semicolons

3655182

style: merge imports from the same modules

e107a13

style: make internal members accessibility explicit

ac80189

refactor(playground): update gestures playground to use latest hammer.js

4d8620c

style(platform-browser): clean up hammer gestures

515befb

fix(compiler): Don’t throw on empty property bindings

fa4c3ab

Closes angular#12583

fix(compiler): dedupe NgModule declarations, …

56b6df8

This is important so that we don’t generate things multiple times.

fix(router): call data observers when the path changes

7968539

refactor(compiler): remove unused subscriptions in view

369945d

refactor(compiler): inline view.viewChildren in generated code

b225f03

refactor(compiler): inline view.contentChildren

a40e883

refactor(compiler): remove view.rootNodes and view.projectableNodes

d9c0eb7

They are replaced by generated visitor functions `view.visitRootNodes` / `view.visitProjectableNodes`.

refactor(compiler): make view.disposable array null if empty

4571dff

refactor(compiler): remove unused constructor query support

b60f03e

fix(compiler): support multiple components in a view container

e76f33f

fix(router): CanDeactivate receives a wrong component

9245e9e

Closes angular#12592

fix(router): routerLink should not prevent default on non-link elements

70a6c54

fix: update public api master file

7bd6cf9

googlebot added the cla: no label Jan 28, 2017

IgorMinar closed this Jan 28, 2017

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

2.1.x #14164

2.1.x #14164

Uh oh!

SteveHu20 commented Jan 28, 2017

Uh oh!

googlebot commented Jan 28, 2017

Uh oh!

IgorMinar commented Jan 28, 2017

Uh oh!

angular-automatic-lock-bot bot commented Sep 10, 2019

Uh oh!

Uh oh!

2.1.x #14164

2.1.x #14164

Uh oh!

Conversation

SteveHu20 commented Jan 28, 2017

Uh oh!

googlebot commented Jan 28, 2017

Uh oh!

IgorMinar commented Jan 28, 2017

Uh oh!

angular-automatic-lock-bot bot commented Sep 10, 2019

Uh oh!

Uh oh!