refactor(compiler-cli): move the expression expression type checker#16562
refactor(compiler-cli): move the expression expression type checker#16562jasonaden merged 1 commit intoangular:masterfrom
Conversation
There was a problem hiding this comment.
Consider moving this out of this file as it seems more general than the scope of this file.
packages/compiler-cli/index.ts
Outdated
There was a problem hiding this comment.
These exports are only used for tests, right? Consider using a deep import in the tests then.
This way it is clearer which methods are supposed to be used (e.g. by the language service) and which ones are just helpers.
There was a problem hiding this comment.
This also exists in the compiler-cli now, did you forget to delete it from the language service?
chuckjaz
force-pushed
the
move-expression-diagnostics
branch
3 times, most recently
from
a1cc5c9 to
0dbda8a
Compare
The expression type checker moved from the language service to the compiler-cli in preparation to using it to check template expressions.
chuckjaz
force-pushed
the
move-expression-diagnostics
branch
from
0dbda8a to
1b6a93d
Compare
…ngular#16562) The expression type checker moved from the language service to the compiler-cli in preparation to using it to check template expressions.
…ngular#16562) The expression type checker moved from the language service to the compiler-cli in preparation to using it to check template expressions.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
The expression type checker moved from the language service
to the compiler-cli in preparation to using it to check
template expressions.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
The template type checker is part of the language service.
What is the new behavior?
The template type checker is part of the compiler cli.
Does this PR introduce a breaking change? (check one with "x")