Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use image based cache for windows BuildKite #27990

Closed
wants to merge 1 commit into from
Closed

ci: use image based cache for windows BuildKite #27990

wants to merge 1 commit into from

Conversation

filipesilva
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@filipesilva filipesilva requested a review from a team as a code owner January 8, 2019 16:46
@kara kara added the area: build & ci Related the build and CI infrastructure of the project label Jan 8, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jan 8, 2019
@filipesilva filipesilva added the target: major This PR is targeted for the next major release label Jan 8, 2019
gkalpak
gkalpak approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable (afaict 😁)

.buildkite/dockerfiles/windows-test.Dockerfile
@@ -0,0 +1,20 @@
# Use the a previous image as source.
FROM gcr.io/internal-200822/angular-windows:master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does internal-200822 come from? Would be a good idea to add a comment for future reference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is our internal google cloud project where the machines are. Will mention that.

.buildkite/dockerfiles/linux-env.Dockerfile Outdated
@@ -0,0 +1,32 @@
ARG target=node:10.12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this file used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nowhere, it was a bad rebase. Good catch, removing it!

This was referenced Jan 9, 2019
Merged
Closed
@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 9, 2019
@ngbot
Copy link

ngbot bot commented Jan 9, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: legacy-unit-tests-saucelabs" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alexeagle
Copy link
Contributor

caretaker: known failures of legacy-unit-tests-saucelabs see #caretaker

@filipesilva filipesilva deleted the buildkite-docker-cache branch January 14, 2019 14:42
This was referenced Jan 14, 2019
Closed
Closed
Closed
alxhub pushed a commit that referenced this pull request Jan 18, 2019
@filipesilva @alxhub
revert: "ci: use image based cache for windows BuildKite (#27990)" (#…
7bdf3fe 
…28160)

This reverts commit eb1aae4.

PR Close #28160
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@filipesilva @ngfelixl
ci: use image based cache for windows BuildKite (angular#27990)
16bb92b 
PR Close angular#27990
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@filipesilva @ngfelixl
revert: "ci: use image based cache for windows BuildKite (angular#27990…
f4d7580 
…)" (angular#28160)

This reverts commit eb1aae4.

PR Close angular#28160
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
5 participants
@filipesilva @alexeagle @gkalpak @kara @googlebot