build: Remove cc_binary dependency on brotli#29912
Closed
alexeagle wants to merge 1 commit intoangular:masterfrom
Closed
build: Remove cc_binary dependency on brotli#29912alexeagle wants to merge 1 commit intoangular:masterfrom
alexeagle wants to merge 1 commit intoangular:masterfrom
Conversation
alexeagle
force-pushed
the
rm_cc_dep
branch
2 times, most recently
from
0329aea to
13c9984
Compare
filipesilva
approved these changes
Apr 16, 2019
Contributor
filipesilva
left a comment
filipesilva
left a comment
There was a problem hiding this comment.
Current errors seem unrelated to the changes in this PR.
The lighthouse score one is #29910, and the integration test one is fixed by angular/angular-cli#14180.
Just use the JavaScript port instead. We don't care about speed since we compress once as a build step.
alexeagle
added
target: major
benlesh
added
the
area: build & ci
Contributor
Contributor
Author
|
assist: fails on two already-broken targets |
alexeagle
added
the
merge: caretaker note
benlesh
added
action: review
Contributor
|
Caretaker note: Merged on @filipesilva's review. |
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
Just use the JavaScript port instead. We don't care about speed since we compress once as a build step. PR Close angular#29912
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just use the JavaScript port instead. We don't care about speed since we compress once as a build step.