Skip to content

build(core): add missing tsconfig-build.json dependency#31943

Closed
petebacondarwin wants to merge 1 commit intoangular:masterfrom
petebacondarwin:tsconfig-rule-fix
Closed

build(core): add missing tsconfig-build.json dependency#31943
petebacondarwin wants to merge 1 commit intoangular:masterfrom
petebacondarwin:tsconfig-rule-fix

Conversation

@petebacondarwin
Copy link
Contributor

For some reason (on OS/X) this transitive dependency is not being passed
through to the final TS builds that rely on this rule, so the build fails
with a missing file error:

The specified path does not exist:
'/.../sandbox/darwin-sandbox/451/execroot/angular/packages/tsconfig-build.json'.

@petebacondarwin petebacondarwin added type: bug/fix area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer severity3: broken target: patch This PR is targeted for the next patch release area: bazel Issues related to the published `@angular/bazel` build rules labels Aug 1, 2019
@petebacondarwin petebacondarwin requested a review from a team August 1, 2019 08:57
@ngbot ngbot bot modified the milestone: needsTriage Aug 1, 2019
For some reason (on OS/X) this transitive dependency is not being passed
through to the final TS builds that rely on this rule, so the build fails
with a missing file error:

```
The specified path does not exist:
'/.../sandbox/darwin-sandbox/451/execroot/angular/packages/tsconfig-build.json'.
```
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems odd that we would have to include this since its part of //packages:tsconfig-test, but if this works then great!

@gregmagolan gregmagolan self-requested a review August 1, 2019 18:09
Copy link
Contributor

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A bug in ts_config is the underlying issue. I'll fix it up in rules_nodejs and then this work-around can be removed on the next rules_nodejs update.

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 14, 2019
@gregmagolan
Copy link
Contributor

gregmagolan commented Aug 14, 2019

Underlying issue fixed by bazel-contrib/rules_nodejs#1009.
Was able to reproduce locally on OSX but not on buildkite OSX, however, on buildkite was able to reproduce on RBE: https://buildkite.com/bazel/rules-nodejs-nodejs/builds/3530#04b1af52-da71-4d28-9430-e72d6da1d2bb
Fix will be in the next rules_nodejs release and I'll clean up this with the rules_nodejs update. This can be merged.

gregmagolan added a commit to bazel-contrib/rules_nodejs that referenced this pull request Aug 14, 2019
gregmagolan added a commit to bazel-contrib/rules_nodejs that referenced this pull request Aug 14, 2019
AndrewKushnir pushed a commit that referenced this pull request Aug 14, 2019
For some reason (on OS/X) this transitive dependency is not being passed
through to the final TS builds that rely on this rule, so the build fails
with a missing file error:

```
The specified path does not exist:
'/.../sandbox/darwin-sandbox/451/execroot/angular/packages/tsconfig-build.json'.
```

PR Close #31943
@gregmagolan gregmagolan mentioned this pull request Aug 15, 2019
14 tasks
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
For some reason (on OS/X) this transitive dependency is not being passed
through to the final TS builds that rely on this rule, so the build fails
with a missing file error:

```
The specified path does not exist:
'/.../sandbox/darwin-sandbox/451/execroot/angular/packages/tsconfig-build.json'.
```

PR Close angular#31943
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants