build(core): add missing tsconfig-build.json dependency#31943
build(core): add missing tsconfig-build.json dependency#31943petebacondarwin wants to merge 1 commit intoangular:masterfrom
Conversation
For some reason (on OS/X) this transitive dependency is not being passed through to the final TS builds that rely on this rule, so the build fails with a missing file error: ``` The specified path does not exist: '/.../sandbox/darwin-sandbox/451/execroot/angular/packages/tsconfig-build.json'. ```
f3cb82a to
a12cde0
Compare
josephperrott
left a comment
There was a problem hiding this comment.
It seems odd that we would have to include this since its part of //packages:tsconfig-test, but if this works then great!
gregmagolan
left a comment
There was a problem hiding this comment.
LGTM. A bug in ts_config is the underlying issue. I'll fix it up in rules_nodejs and then this work-around can be removed on the next rules_nodejs update.
|
Underlying issue fixed by bazel-contrib/rules_nodejs#1009. |
For some reason (on OS/X) this transitive dependency is not being passed through to the final TS builds that rely on this rule, so the build fails with a missing file error: ``` The specified path does not exist: '/.../sandbox/darwin-sandbox/451/execroot/angular/packages/tsconfig-build.json'. ``` PR Close #31943
For some reason (on OS/X) this transitive dependency is not being passed through to the final TS builds that rely on this rule, so the build fails with a missing file error: ``` The specified path does not exist: '/.../sandbox/darwin-sandbox/451/execroot/angular/packages/tsconfig-build.json'. ``` PR Close angular#31943
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
For some reason (on OS/X) this transitive dependency is not being passed
through to the final TS builds that rely on this rule, so the build fails
with a missing file error: