Skip to content

Conversation

@alexeagle
Copy link
Contributor

@alexeagle alexeagle commented Jan 27, 2017

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

behavior is unchanged - pure refactoring

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@alexeagle alexeagle added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 27, 2017
@alexeagle alexeagle requested a review from mhevery January 27, 2017 18:27
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note @chuckjaz this has your #14124 included here

@alexeagle alexeagle force-pushed the refactor_integration_tests branch from d4d0989 to 4d57b2d Compare January 27, 2017 19:21
@alexeagle alexeagle force-pushed the refactor_integration_tests branch from 4d57b2d to 4e57dca Compare January 27, 2017 23:10
@alexeagle alexeagle added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 27, 2017
@alexeagle alexeagle force-pushed the refactor_integration_tests branch from 4e57dca to 0b413e1 Compare January 28, 2017 00:26
@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Jan 28, 2017
@mhevery mhevery closed this in c48dd76 Jan 31, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants