Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): roll back breaking change with min/max directives #17622

Merged
merged 2 commits into from Jun 20, 2017

Conversation

@hansl
Copy link
Contributor

commented Jun 19, 2017

With 4.2, we introduced the min and max validator directives. This was actually a breaking change because their selectors could include custom value accessors using the min/max properties for their own purposes.

For now, we are rolling back the change by removing the exports. At the least, we should wait to add them until a major version. In the meantime, we will have further discussion about what the best solution is going forward for all validator directives.

Closes #17491.


PR #17551 tried to roll this back, but did not remove the dead code. This failed internal tests that were checking that all declared directives were used.
This PR rolls back the original PR and commit the same as #17551 while also removing the dead code.

@googlebot googlebot added the cla: yes label Jun 19, 2017

@hansl hansl requested review from IgorMinar and chuckjaz Jun 19, 2017

@hansl

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2017

@kara notification that we reverted the original PR and to revert ONLY the last commit on this PR as a starting point when reimplementing those features.

fix(forms): roll back breaking change with min/max directives
With 4.2, we introduced the min and max validator directives. This was actually a breaking change because their selectors could include custom value accessors using the min/max properties for their own purposes.

For now, we are rolling back the change by removing the exports. At the least, we should wait to add them until a major version. In the meantime, we will have further discussion about what the best solution is going forward for all validator directives.

Closes #17491.

----

PR #17551 tried to roll this back, but did not remove the dead code. This failed internal tests that were checking that all declared directives were used.
This PR rolls back the original PR and commit the same as #17551 while also removing the dead code.

@hansl hansl force-pushed the hansl:min-max-rollback branch from 5acfdbd to 803dd3b Jun 19, 2017

@mary-poppins

This comment has been minimized.

Copy link

commented Jun 19, 2017

The angular.io preview for 5acfdbd is available here.

@mary-poppins

This comment has been minimized.

Copy link

commented Jun 19, 2017

The angular.io preview for 803dd3b is available here.

@hansl hansl requested a review from tinayuangao Jun 20, 2017

@hansl

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2017

I'm going to merge this as it passes travis and tap. This will unblock the queue.

@hansl hansl merged commit 3e685f9 into angular:master Jun 20, 2017

3 of 4 checks passed

code-review/pullapprove Approval required by 1 of: IgorMinar, kara, mhevery, tinayuangao
Details
ci/circleci Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hansl hansl deleted the hansl:min-max-rollback branch Jun 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.