Skip to content

refactor(build): rename fesm -> esm and publish as package.js rather than index.js #19190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jasonaden wants to merge 2 commits into from
Closed

refactor(build): rename fesm -> esm and publish as package.js rather than index.js #19190

jasonaden wants to merge 2 commits into from

Conversation

@jasonaden
Copy link
Contributor

@jasonaden jasonaden commented Sep 14, 2017

No description provided.

@jasonaden jasonaden force-pushed the refactor_change_fesm_name branch from 325ea30 to bcc8555 Compare September 14, 2017 00:43
@mary-poppins
Copy link

mary-poppins commented Sep 14, 2017

You can preview 325ea30 at https://pr19190-325ea30.ngbuilds.io/.

@mary-poppins
Copy link

mary-poppins commented Sep 14, 2017

You can preview bcc8555 at https://pr19190-bcc8555.ngbuilds.io/.

@jasonaden jasonaden force-pushed the refactor_change_fesm_name branch from bcc8555 to 76723dc Compare September 14, 2017 01:19
@mary-poppins
Copy link

mary-poppins commented Sep 14, 2017

You can preview 76723dc at https://pr19190-76723dc.ngbuilds.io/.

@jasonaden jasonaden force-pushed the refactor_change_fesm_name branch 2 times, most recently from 0153da7 to 9c4f768 Compare September 14, 2017 17:28
@mary-poppins
Copy link

mary-poppins commented Sep 14, 2017

You can preview 9c4f768 at https://pr19190-9c4f768.ngbuilds.io/.

@jasonaden jasonaden force-pushed the refactor_change_fesm_name branch from 9c4f768 to 11cba57 Compare September 14, 2017 18:11
@mary-poppins
Copy link

mary-poppins commented Sep 14, 2017

You can preview 11cba57 at https://pr19190-11cba57.ngbuilds.io/.

@jasonaden jasonaden added area: build & ci Related the build and CI infrastructure of the project action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Sep 14, 2017
@jasonaden jasonaden force-pushed the refactor_change_fesm_name branch from 11cba57 to a9acb3a Compare September 14, 2017 18:53
@mary-poppins
Copy link

mary-poppins commented Sep 14, 2017

You can preview a9acb3a at https://pr19190-a9acb3a.ngbuilds.io/.

@jasonaden jasonaden force-pushed the refactor_change_fesm_name branch from a9acb3a to 1b57fed Compare September 14, 2017 19:21
@mary-poppins
Copy link

mary-poppins commented Sep 14, 2017

You can preview 1b57fed at https://pr19190-1b57fed.ngbuilds.io/.

@mattlewis92 mattlewis92 mentioned this pull request Sep 15, 2017
Closed
@jasonaden jasonaden force-pushed the refactor_change_fesm_name branch from 1b57fed to b68f010 Compare September 18, 2017 17:26
@mary-poppins
Copy link

mary-poppins commented Sep 18, 2017

You can preview b68f010 at https://pr19190-b68f010.ngbuilds.io/.

@IgorMinar IgorMinar closed this in 15e8d50 Sep 20, 2017
IgorMinar pushed a commit that referenced this pull request Sep 20, 2017
@jasonaden @IgorMinar
build: update public api file names (#19190)
79c7fe0 
PR Close #19190
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 12, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@mhevery mhevery mhevery approved these changes

@vicb vicb vicb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jasonaden @mary-poppins @mhevery @vicb @googlebot