Skip to content

build: update browserstack key#23026

Closed
josephperrott wants to merge 1 commit intoangular:masterfrom
josephperrott:browser-stack-key
Closed

build: update browserstack key#23026
josephperrott wants to merge 1 commit intoangular:masterfrom
josephperrott:browser-stack-key

Conversation

@josephperrott
Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
Update BrowserStack key.

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

BrowserStack fails.

What is the new behavior?

BrowserStack works!

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@matsko matsko added the target: patch This PR is targeted for the next patch release label Mar 27, 2018
@matsko matsko changed the title chore(ci): update browserstack key build(ci): update browserstack key Mar 27, 2018
@matsko matsko changed the title build(ci): update browserstack key build: update browserstack key Mar 27, 2018
@matsko matsko self-requested a review March 27, 2018 18:54
@matsko matsko added the action: merge The PR is ready for merge by the caretaker label Mar 27, 2018
@ngbot
Copy link
Copy Markdown

ngbot bot commented Mar 27, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing
    pending status "code-review/pullapprove" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@matsko matsko closed this in ab348ee Mar 27, 2018
matsko pushed a commit that referenced this pull request Mar 27, 2018
@josephperrott josephperrott deleted the browser-stack-key branch March 28, 2018 16:17
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants