fix: add mappings for ngfactory & ngsummary files to module names in aot summary resolver#25335
Closed
gregmagolan wants to merge 1 commit intoangular:masterfrom
gregmagolan:amd-module-name-for-ngfactory
Closed
fix: add mappings for ngfactory & ngsummary files to module names in aot summary resolver#25335gregmagolan wants to merge 1 commit intoangular:masterfrom gregmagolan:amd-module-name-for-ngfactory
gregmagolan wants to merge 1 commit intoangular:masterfrom
gregmagolan:amd-module-name-for-ngfactory
Conversation
alexeagle
approved these changes
Aug 6, 2018
Contributor
alexeagle
left a comment
alexeagle
left a comment
There was a problem hiding this comment.
In a follow-up PR, please convert integration/bazel (or make a new integration/bazel_src) that tests this
|
You can preview bb3e905 at https://pr25335-bb3e905.ngbuilds.io/. |
gregmagolan
changed the title
|
You can preview 48198f5 at https://pr25335-48198f5.ngbuilds.io/. |
…es in aot summary resolver
|
You can preview 041b2e9 at https://pr25335-041b2e9.ngbuilds.io/. |
|
You can preview 3d371f9 at https://pr25335-3d371f9.ngbuilds.io/. |
vicb
approved these changes
Aug 7, 2018
matsko
pushed a commit
that referenced
this pull request
Aug 23, 2018
… ngfactory & ngsummary files (#25604) Workaround was added in #25335. It was necessary for .ngfactory & .ngsummary files to have proper AMD module names starting with @angular when building angular downstream from source using Bazel. The underlying issue has been resolved in the compiler and these files now get proper AMD module names without the need for this workaround. The workaround had an unexpected consequence angular/angular-cli#11835 which is fixed by its removal. PR Close #25604
matsko
pushed a commit
that referenced
this pull request
Aug 23, 2018
… ngfactory & ngsummary files (#25604) Workaround was added in #25335. It was necessary for .ngfactory & .ngsummary files to have proper AMD module names starting with @angular when building angular downstream from source using Bazel. The underlying issue has been resolved in the compiler and these files now get proper AMD module names without the need for this workaround. The workaround had an unexpected consequence angular/angular-cli#11835 which is fixed by its removal. PR Close #25604
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building angular from source using bazel downstream, the ngfactory & ngsummary files generated in the angular build also need to be mapped to their module names.
This PR makes bazelbuild/rules_typescript#223 unnecessary.