Skip to content

docs(forms): update API reference for reactive and template-driven forms modules#25687

Closed
brandonroberts wants to merge 1 commit intoangular:masterfrom
brandonroberts:form-providers-api-ref
Closed

docs(forms): update API reference for reactive and template-driven forms modules#25687
brandonroberts wants to merge 1 commit intoangular:masterfrom
brandonroberts:form-providers-api-ref

Conversation

@brandonroberts
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@brandonroberts brandonroberts added comp: docs area: forms target: patch This PR is targeted for the next patch release state: community Someone from the Angular community is working on this issue or submitted this PR labels Aug 27, 2018
@brandonroberts brandonroberts requested a review from kara August 27, 2018 15:14
@mary-poppins
Copy link
Copy Markdown

You can preview 79a279c at https://pr25687-79a279c.ngbuilds.io/.

@brandonroberts brandonroberts removed the state: community Someone from the Angular community is working on this issue or submitted this PR label Aug 27, 2018
Copy link
Copy Markdown
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe confusing to have both forms guides here? Remove the reactive forms one?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: formatting

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when an ngModelbinding is used with reactive form directives.

@kara kara added the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 30, 2018
@brandonroberts brandonroberts force-pushed the form-providers-api-ref branch from 79a279c to 0982ff9 Compare August 31, 2018 14:09
@mary-poppins
Copy link
Copy Markdown

You can preview 0982ff9 at https://pr25687-0982ff9.ngbuilds.io/.

Copy link
Copy Markdown
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 31, 2018
@kara kara removed their assignment Aug 31, 2018
@kara kara added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Aug 31, 2018
@mhevery mhevery closed this in abd29f5 Aug 31, 2018
mhevery pushed a commit that referenced this pull request Aug 31, 2018
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: forms cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants