test: move remaining fixmeIvy to test level #27354
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview c5cf06b at https://pr27354-c5cf06b.ngbuilds.io/. |
crisbeto
added
the
action: review
kara
suggested changes
Nov 29, 2018
There was a problem hiding this comment.
Can you add a description for the issue here, in addition to the issue #? Otherwise our grep command won't pick it up.
kara
added
the
action: cleanup
crisbeto
force-pushed
the
fixme-describe-cleanup
branch
from
c5cf06b to
f8cf019
Compare
crisbeto
removed
the
action: cleanup
|
I've addressed the feedback @kara. |
|
You can preview f8cf019 at https://pr27354-f8cf019.ngbuilds.io/. |
kara
added
action: cleanup
Moves all of the remaning `describe`-level fixme instances to the `it` level.
crisbeto
force-pushed
the
fixme-describe-cleanup
branch
from
f8cf019 to
7842561
Compare
|
You can preview 7842561 at https://pr27354-7842561.ngbuilds.io/. |
crisbeto
added
action: merge
mhevery
approved these changes
Nov 29, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all of the remaning
describe-level fixme instances to theitlevel.