Skip to content

fix(ivy): @Host should behave as in View Engine #27646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix(ivy): @Host should behave as in View Engine #27646

wants to merge 3 commits into from

Conversation

@marclaval
Copy link
Contributor

@marclaval marclaval commented Dec 13, 2018

This PR follows discussions that happened in #27387 and #27444.

The implemented rule is: when @Host is added, from the host itself, only viewProviders and the component can be found, providers and other directives can't.

@mary-poppins
Copy link

mary-poppins commented Dec 13, 2018

You can preview 313f1b7 at https://pr27646-313f1b7.ngbuilds.io/.

@mary-poppins
Copy link

mary-poppins commented Dec 13, 2018

You can preview 4db17b3 at https://pr27646-4db17b3.ngbuilds.io/.

@mary-poppins
Copy link

mary-poppins commented Dec 13, 2018

You can preview 6df045a at https://pr27646-6df045a.ngbuilds.io/.

@mary-poppins
Copy link

mary-poppins commented Dec 13, 2018

You can preview 930f2f1 at https://pr27646-930f2f1.ngbuilds.io/.

@mary-poppins
Copy link

mary-poppins commented Dec 13, 2018

You can preview 835ed8c at https://pr27646-835ed8c.ngbuilds.io/.

@mary-poppins
Copy link

mary-poppins commented Dec 13, 2018

You can preview ffd86aa at https://pr27646-ffd86aa.ngbuilds.io/.

@marclaval marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Dec 13, 2018
@ngbot ngbot bot added this to the needsTriage milestone Dec 13, 2018
kara
kara suggested changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

@kara kara added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 14, 2018
@mhevery mhevery self-assigned this Dec 14, 2018
@mary-poppins
Copy link

mary-poppins commented Dec 17, 2018

You can preview fb1e95d at https://pr27646-fb1e95d.ngbuilds.io/.

@mary-poppins
Copy link

mary-poppins commented Dec 17, 2018

You can preview 10492fc at https://pr27646-10492fc.ngbuilds.io/.

kara
kara suggested changes Dec 17, 2018
View reviewed changes
@mary-poppins
Copy link

mary-poppins commented Dec 19, 2018

You can preview c718b17 at https://pr27646-c718b17.ngbuilds.io/.

kara
kara approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 19, 2018
@kara
Copy link
Contributor

kara commented Dec 19, 2018

presubmit

@kara kara added the action: merge The PR is ready for merge by the caretaker label Dec 19, 2018
@matsko matsko closed this in 8f8572f Dec 19, 2018
@mhevery mhevery mentioned this pull request Jan 2, 2019
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kara kara kara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mhevery mhevery

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

5 participants

@marclaval @mary-poppins @kara @mhevery @googlebot