test(ivy): diagnose root causes for MatInput#29153
Closed
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
Closed
test(ivy): diagnose root causes for MatInput#29153pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
pkozlowski-opensource wants to merge 1 commit intoangular:masterfrom
Conversation
pkozlowski-opensource
added
action: review
skreborn
suggested changes
Mar 7, 2019
Contributor
skreborn
left a comment
skreborn
left a comment
There was a problem hiding this comment.
One minor typo is all I could find.
Contributor
There was a problem hiding this comment.
Suggested change
| fixmeIvy('FW-1143: Views created through ComponentFactory-ies are change-detected to early') | |
| fixmeIvy('FW-1143: Views created through ComponentFactory-ies are change-detected too early') |
Contributor
There was a problem hiding this comment.
Suggested change
| "notes": "FW-1143: Views created through ComponentFactory-ies are change-detected to early" | |
| "notes": "FW-1143: Views created through ComponentFactory-ies are change-detected too early" |
pkozlowski-opensource
force-pushed
the
mat_input_diagnose
branch
from
53ace76 to
90158bf
Compare
kara
suggested changes
Mar 7, 2019
pkozlowski-opensource
force-pushed
the
mat_input_diagnose
branch
from
90158bf to
c888ca3
Compare
kara
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR diagnoses one of the root causes for MatInput (the other one is an issue in MatStepper). Additionally there is a failing TestBed case that exposes the problem without the Material dependency.