fix(bazel): prod server doesn't serve files in windows #35991
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
area: bazel
|
Targeting master only because the fix is also dependent on bazel-contrib/rules_nodejs@d635dca which is available only in bazel nodejs rules 1.4.0. |
In Windows runfiles are not always available thus we need to use the real location using rlocation. Related to bazel-contrib/rules_nodejs#1699
gregmagolan
reviewed
Mar 11, 2020
| ['@angular/bazel', angularCore.version], | ||
| ['@bazel/bazel', '2.1.0'], | ||
| ['@bazel/ibazel', '0.11.1'], | ||
| ['@bazel/ibazel', '0.12.2'], |
There was a problem hiding this comment.
nit: also update in root package.json?
There was a problem hiding this comment.
I’ll do that tmr cause I am current AFK
kyliau
approved these changes
Mar 11, 2020
matsko
pushed a commit
that referenced
this pull request
Mar 11, 2020
AndrewKushnir
pushed a commit
that referenced
this pull request
Mar 12, 2020
Follow up on #35991 (comment) PR Close #36033
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows runfiles are not always available thus we need to use the real location using rlocation.
Related to bazel-contrib/rules_nodejs#1699