fix(core): workaround Terser inlining bug#36200
Closed
filipesilva wants to merge 1 commit intoangular:masterfrom
filipesilva:jit-inline-terser
Closed
fix(core): workaround Terser inlining bug#36200filipesilva wants to merge 1 commit intoangular:masterfrom filipesilva:jit-inline-terser
filipesilva wants to merge 1 commit intoangular:masterfrom
filipesilva:jit-inline-terser
Conversation
filipesilva
added
the
target: major
|
You can preview 7aafe15 at https://pr36200-7aafe15.ngbuilds.io/. |
filipesilva
added
the
action: review
JoostK
approved these changes
Mar 23, 2020
Member
JoostK
left a comment
JoostK
left a comment
There was a problem hiding this comment.
What a bizarre bug!
Thanks @filipesilva, @clydin and @dgp1130 for the research and fix! 👍
alxhub
approved these changes
Mar 23, 2020
Member
There was a problem hiding this comment.
Can you include a comment here explaining the bug (maybe link to the Terser issue?) and that the name has to be different?
This variable name change works around terser/terser#615, which was causing the JIT production tests to fail in the Angular CLI repository (angular/angular-cli#17264).
Member
|
You can preview 2f9163c at https://pr36200-2f9163c.ngbuilds.io/. |
alxhub
added
action: merge
mhevery
added
target: patch
mhevery
pushed a commit
that referenced
this pull request
Mar 23, 2020
This variable name change works around terser/terser#615, which was causing the JIT production tests to fail in the Angular CLI repository (angular/angular-cli#17264). PR Close #36200
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This variable name change works around terser/terser#615, which was causing the JIT production tests to fail in the Angular CLI repository (angular/angular-cli#17264).
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: angular/angular-cli#17264
What is the new behavior?
This variable name change works around terser/terser#615, which was causing the JIT production tests to fail in the Angular CLI repository (angular/angular-cli#17264).
Does this PR introduce a breaking change?
Other information