Skip to content

docs(service-worker): fix typos in SwRegistrationOptions API docs #38047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gkalpak wants to merge 1 commit into from
Closed

docs(service-worker): fix typos in SwRegistrationOptions API docs #38047

gkalpak wants to merge 1 commit into from

Conversation

@gkalpak
Copy link
Member

@gkalpak gkalpak commented Jul 14, 2020

☝️

@gkalpak gkalpak added comp: docs area: service-worker Issues related to the @angular/service-worker package action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release type: bug/fix labels Jul 14, 2020
@ngbot ngbot bot added this to the needsTriage milestone Jul 14, 2020
@gkalpak gkalpak marked this pull request as ready for review July 14, 2020 14:40
@mary-poppins
Copy link

mary-poppins commented Jul 14, 2020

You can preview 7a42a70 at https://pr38047-7a42a70.ngbuilds.io/.

@gkalpak gkalpak requested a review from kapunahelewong July 14, 2020 14:47
@AndrewKushnir AndrewKushnir removed the request for review from kapunahelewong July 15, 2020 20:08
AndrewKushnir pushed a commit that referenced this pull request Jul 15, 2020
@gkalpak @AndrewKushnir
docs(service-worker): fix typos in SwRegistrationOptions API docs (#…
ee340b7 
…38047)

PR Close #38047
@gkalpak gkalpak deleted the docs-sw-typos branch July 16, 2020 15:12
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Aug 16, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 16, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@gkalpak @profanis
docs(service-worker): fix typos in SwRegistrationOptions API docs (a…
1cae2f6 
…ngular#38047)

PR Close angular#38047
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: service-worker Issues related to the @angular/service-worker package cla: yes target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

4 participants

@gkalpak @mary-poppins @AndrewKushnir @googlebot