refactor(dev-infra): move shared browser bazel setup into dedicated bazel folder #42268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…azel folder This change moves the `dev-infra/browsers` folder into `dev-infra/bazel`. The browser folder is providing custom configuration for Bazel, so it should live within the `bazel` folder for a more well-structured `dev-infra` folder.
…sts job The shared dev-infra package from `HEAD` should not be installed when running the `components-repo-unit-tests` job. This is done because otherwise changes to the dev-infra package can result in build setup issues for the CI job (while the goal of the CI job is to test the framework)
zarend
added
the
area: dev-infra
devversion
added
action: review
devversion
added
action: merge
jessicajaniuk
pushed a commit
that referenced
this pull request
Jun 3, 2021
…sts job (#42268) The shared dev-infra package from `HEAD` should not be installed when running the `components-repo-unit-tests` job. This is done because otherwise changes to the dev-infra package can result in build setup issues for the CI job (while the goal of the CI job is to test the framework) PR Close #42268
jessicajaniuk
pushed a commit
that referenced
this pull request
Jun 3, 2021
…sts job (#42268) The shared dev-infra package from `HEAD` should not be installed when running the `components-repo-unit-tests` job. This is done because otherwise changes to the dev-infra package can result in build setup issues for the CI job (while the goal of the CI job is to test the framework) PR Close #42268
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the
dev-infra/browsersfolder intodev-infra/bazel.The browser folder is providing custom configuration for Bazel, so it
should live within the
bazelfolder for a more well-structureddev-infrafolder.