Conversation
|
The failure is caused by a bug in UPDATE: @alan-agius4 is working on a fix. |
|
Should be addressed via angular/angular-cli#21160 |
033fd27 to
aee22ec
Compare
|
@gkalpak looks like we need to update the payload sizes. |
|
@alan-agius4, do we know what causes the size increase? (It seems to be coming from the CLI/devkit.) |
|
The increase in runtime is likely caused by trusted types. Regarding the size increase in main, I don’t know if it might be caused by the new version of build-optimizer, or something else. Guess we need check the diffs. |
|
👍 I'll dig into it. |
aee22ec to
14d5274
Compare
This comment has been minimized.
This comment has been minimized.
| "runtime-es2017": 4619, | ||
| "main-es2017": 456437, | ||
| "runtime-es2017": 4841, | ||
| "main-es2017": 458615, |
There was a problem hiding this comment.
FYI, from the ~2KB increase, ~0.5KB come from updating CLI/devkit and ~1.5KB from updating CDK.
This comment has been minimized.
This comment has been minimized.
|
The remaining failures are:
|
46f10c1 to
3913e5a
Compare
|
Still seeing some significant size increase in one test, even with @clydin change #43064 |
|
I was thinking that we should replace https://github.com/angular/angular/blob/master/integration/side-effects/package.json to use the new more correct build-optimizer to help prevent merging of side effects. |
|
Following further investigation it appears that the pure comments are not being emitted. This is caused by TypeScript which will not emit the PURE comment when downlevelling the static properties https://www.typescriptlang.org/play?ssl=3&ssc=2&pln=1&pc=1#code/KYDwDg9gTgLgBAQwEYGcZQQY3pgNglFOASQDsArYbaOAbwFgAoOONBGAS0zgDkBVADICAXCQpUYNALxwA9ACo4AAQD6KgAp8ASgFE1cebLilgAd14BXXLjKVqUABQBKANxMAvkA |
74d0124 to
df86957
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR contains the following updates:
12.1.1->12.2.712.1.1->12.2.712.1.1->12.2.712.1.1->12.2.712.1.1->12.2.712.2.2->12.2.712.1.1->12.2.712.1.1->12.2.712.1.1->12.2.712.2.2->12.2.7e79b008->66f3d7612.1.1->12.2.712.1.1->12.2.712.1.1->12.2.712.1.1->12.2.712.1.1->12.2.712.1.1->12.2.712.1.1->12.2.77679cff->f64f808🔡 If you wish to disable git hash updates, add
":disableDigestUpdates"to the extends array in your config.Release Notes
angular/angular-cli
v12.2.7Compare Source
@angular-devkit/build-angular
Special Thanks
Alan Agius and Charles Lyding
v12.2.6Compare Source
@angular/cli
FORCE_COLORwhen stdout is not instance ofWriteStream@angular-devkit/build-angular
FORCE_COLORwhen stdout is not instance ofWriteStreamSpecial Thanks
Alan Agius
v12.2.5Compare Source
@angular-devkit/build-angular
Special Thanks:
Alan Agius and Charles Lyding
v12.2.4Compare Source
@angular-devkit/build-angular
esbuildto0.12.24mini-css-extract-pluginto2.2.1Special Thanks
Alan Agius
v12.2.3Compare Source
@angular-devkit/build-angular
Special Thanks:
Alan Agius and Trevor Karjanis
v12.2.2Compare Source
@angular-devkit/build-angular
@ngtools/webpack
Special Thanks:
Alan Agius, Charles Lyding, Joey Perrott and Simon Primetzhofer
v12.2.1Compare Source
@angular/cli
--skip-confirmationduringng add@angular-devkit/schematics-cli
@angular-devkit/build-angular
Special Thanks:
Alan Agius and Charles Lyding
v12.2.0Compare Source
@angular/cli
YARN_environment variables duringng updateandng addng version@angular-devkit/build-angular
sourceMappingoption to false.NG_PERSISTENT_BUILD_CACHEalways creates a cache in the specified cache directory@media allcausing critical CSS inling to failextractLicensesdidn't have an effect when using server builderoutputPathfrom persistent build cache keyesbuildas a CSS optimizer for component stylesENOENTandENOTDIRerrors when deleting outputsfor await...ofwhen targetting ES2018+esbuildandterseras a JavaScript optimizer@angular-devkit/build-webpack
@ngtools/webpack
@schematics/angular
divwithbuttonin application component templatekarma-jasmine-html-reporterSpecial Thanks:
Alan Agius, Charles Lyding, David Scourfield, Doug Parker, hien-pham, Joey Perrott, LeonEck, Mike
Jancar, twerske, Vaibhav Singh and originalfrostig
v12.1.4Compare Source
@angular/cli
@schematics/angular
@angular-devkit/build-angular
@angular-devkit/build-webpack
Special Thanks:
Alan Agius, Charles Lyding, Joey Perrott and originalfrostig
v12.1.3Compare Source
@angular/cli
YARN_environment variables duringng updateandng add@angular-devkit/build-angular
Special Thanks:
Alan Agius, Charles Lyding, Joey Perrott, LeonEck and Mike Jancar
v12.1.2Compare Source
angular/angular
v12.2.7Compare Source
common
compiler
compiler-cli
platform-browser
Special Thanks
Andrew Scott, Daniel Díaz, George Kalpakas, JoostK, Kristiyan Kostadinov, Mwiku, Pete Bacon Darwin, Teri Glover, Virginia Dooley, Xiaohanxu1996, dario-piotrowicz and kirjs
v12.2.6Compare Source
animations
core
router
service-worker
Special Thanks
Alan Agius, Amadou Sall, Andrew Kushnir, Andrew Scott, Aristeidis Bampakos, Bjarki, David Shevitz, George Kalpakas, Joe Martin (Crowdstaffing), Michele Stieven, Naveed Ahmed, dario-piotrowicz, mezhik91 and mgechev
v12.2.5Compare Source
router
Unhandled Navigation Error(#43291)Special Thanks:
Alan Agius, Charles Barnes, Enea Jahollari, George Kalpakas, Ikko Ashimine, Paul Gschwendtner, Pete Bacon Darwin, William Sedlacek and dario-piotrowicz
v12.2.4Compare Source
compiler-cli
Special Thanks:
Andrew Scott, Daniel Trevino, George Kalpakas, Joey Perrott, Kristiyan Kostadinov, nickreid and segunb
v12.2.3Compare Source
service-worker
Special Thanks:
Daniel Trevino, Erik Slack, George Kalpakas, dario-piotrowicz and shlasouski
v12.2.2Compare Source
animations
core
platform-browser
router
Special Thanks:
Andrew Scott, Aristeidis Bampakos, Charles Lyding, Edoardo Dusi, George Kalpakas, Joe Martin (Crowdstaffing), Joey Perrott, Kirk Larkin, Kristiyan Kostadinov, Pete Bacon Darwin, TIffany Davis, Theoklitos Bampouris, ali, dario-piotrowicz and pichuser
v12.2.1Compare Source
router
Special Thanks:
Amadou Sall, Andrew Kushnir, Andrew Scott, Daniel Trevino, Erik Slack, Fabien BERNARD, George Kalpakas, Jeroen van Warmerdam, Joey Perrott, Tim Gates and Vugar_Abdullayev
v12.2.0Compare Source
core
language-service
Special Thanks:
Alex Rickabaugh, Joe Martin, Joey Perrott, Kristiyan Kostadinov, Nichola Alkhouri, Paul Gschwendtner, Pete Bacon Darwin, atscott, dario-piotrowicz and ivanwonder
v12.1.5Compare Source
This release contains various API docs improvements.
v12.1.4Compare Source
compiler-cli
core
nullorundefinedinErrorHandler#handleError()(#42881)Special Thanks:
Andrew Scott, Daniel Trevino, Dylan Hunn, George Kalpakas, Joey Perrott, JoostK, Paul Gschwendtner, Pete Bacon Darwin, Teri Glover, Vladyslav, Yuvaraj and codebriefcase
v12.1.3Compare Source
animations
compiler-cli
forwardRef(#42887)core
Special Thanks:
Alan Agius, David Shevitz, George Kalpakas, Joey Perrott, JoostK, Krzysztof Kotowicz, Minko Gechev, Paul Gschwendtner and dario-piotrowicz
v12.1.2Compare Source
bazel
common
KeyValuePipewhencompareFnchanges (#42821)compiler
compiler-cli
core
ngForis used with atrackByfunction (#42692)language-service
Configuration
📅 Schedule: "after 10pm every weekday,before 4am every weekday,every weekend" in timezone America/Tijuana.
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by WhiteSource Renovate. View repository job log here.