Skip to content

build: update angular#42598

Closed
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/angular
Closed

build: update angular#42598
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/angular

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Jun 18, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@angular-devkit/build-angular 12.1.1 -> 12.2.7 age adoption passing confidence
@angular/animations 12.1.1 -> 12.2.7 age adoption passing confidence
@angular/cdk 12.1.1 -> 12.2.7 age adoption passing confidence
@angular/cli 12.1.1 -> 12.2.7 age adoption passing confidence
@angular/common 12.1.1 -> 12.2.7 age adoption passing confidence
@angular/common-12 12.2.2 -> 12.2.7 age adoption passing confidence
@angular/compiler 12.1.1 -> 12.2.7 age adoption passing confidence
@angular/compiler-cli 12.1.1 -> 12.2.7 age adoption passing confidence
@angular/core 12.1.1 -> 12.2.7 age adoption passing confidence
@angular/core-12 12.2.2 -> 12.2.7 age adoption passing confidence
@angular/dev-infra-private e79b008 -> 66f3d76 age adoption passing confidence
@angular/elements 12.1.1 -> 12.2.7 age adoption passing confidence
@angular/forms 12.1.1 -> 12.2.7 age adoption passing confidence
@angular/material 12.1.1 -> 12.2.7 age adoption passing confidence
@angular/platform-browser 12.1.1 -> 12.2.7 age adoption passing confidence
@angular/platform-browser-dynamic 12.1.1 -> 12.2.7 age adoption passing confidence
@angular/router 12.1.1 -> 12.2.7 age adoption passing confidence
@angular/service-worker 12.1.1 -> 12.2.7 age adoption passing confidence
angular/dev-infra 7679cff -> f64f808 age adoption passing confidence

🔡 If you wish to disable git hash updates, add ":disableDigestUpdates" to the extends array in your config.


Release Notes

angular/angular-cli

v12.2.7

Compare Source

@​angular-devkit/build-angular
Commit Type Description
d856b4d23 fix support WASM-based esbuild optimizer fallback

Special Thanks

Alan Agius and Charles Lyding

v12.2.6

Compare Source

@​angular/cli
Commit Type Description
8b21effad fix handle FORCE_COLOR when stdout is not instance of WriteStream
@​angular-devkit/build-angular
Commit Type Description
ea60f0f52 fix handle FORCE_COLOR when stdout is not instance of WriteStream

Special Thanks

Alan Agius

v12.2.5

Compare Source

@​angular-devkit/build-angular
Commit Type Description
0498768c5 fix disable dev-server response compression
367fce2e9 fix improve Safari browserslist to esbuild target conversion

Special Thanks:

Alan Agius and Charles Lyding

v12.2.4

Compare Source

@​angular-devkit/build-angular
Commit Type Description
aaadef026 fix update esbuild to 0.12.24
f8a9f4a01 fix update mini-css-extract-plugin to 2.2.1

Special Thanks

Alan Agius

v12.2.3

Compare Source

@​angular-devkit/build-angular
Commit Type Description
3e3321857 fix RGBA converted to hex notation in component styles breaks IE11

Special Thanks:

Alan Agius and Trevor Karjanis

v12.2.2

Compare Source

@​angular-devkit/build-angular
Commit Description
a55118a75 fix: provide supported browsers to esbuild
81baa4f95 fix: update Angular peer dependencies to 12.2 stable
297410ae8 fix: handle undefined entrypoints when marking async chunks
@​ngtools/webpack
Commit Description
b7199f366 fix: update Angular peer dependencies to 12.2 stable

Special Thanks:

Alan Agius, Charles Lyding, Joey Perrott and Simon Primetzhofer

v12.2.1

Compare Source

@​angular/cli
Commit Description
8dc3c895a fix(@​angular/cli): show error when using non-TTY terminal without passing --skip-confirmation during ng add
@​angular-devkit/schematics-cli
Commit Description
eded01270 fix(@​angular-devkit/schematics-cli): log when in debug and/or dry run modes
@​angular-devkit/build-angular
Commit Description
22e0208a9 fix(@​angular-devkit/build-angular): ensure native async is downlevelled in third-party libraries
9b4b86fb0 fix(@​angular-devkit/build-angular): support both pure annotation forms for static properties
cea028090 fix(@​angular-devkit/build-angular): do not consume inline sourcemaps when vendor sourcemaps is disabled.
e7ec0346e fix(@​angular-devkit/build-angular): avoid attempting to optimize copied JavaScript assets
4f757c2bc fix(@​angular-devkit/build-angular): handle null maps in JavaScript optimizer worker

Special Thanks:

Alan Agius and Charles Lyding

v12.2.0

Compare Source

@​angular/cli
Commit Description
259e26979 fix(@​angular/cli): merge npmrc files values
c1eddbdc9 fix(@​angular/cli): handle YARN_ environment variables during ng update and ng add
6b00d1270 fix(@​angular/cli): handle NPM_CONFIG environment variables during ng update and ng add
88ee85c41 fix(@​angular/cli): disable update notifier when retrieving package manager version during ng version
@​angular-devkit/build-angular
Commit Description
d750c686f fix(@​angular-devkit/build-angular): add priority to copy-webpack-plugin patterns
4bcd1dc9e fix(@​angular-devkit/build-angular): allow classes with pure annotated static properties to be optimized
ceade0c27 fix(@​angular-devkit/build-angular): dasherize disable-host-check suggestion
8383c6b42 fix(@​angular-devkit/build-angular): silence Sass compiler warnings from 3rd party stylesheets
07763702f fix(@​angular-devkit/build-angular): force linker sourceMapping option to false.
a5c69722f fix(@​angular-devkit/build-angular): ensure NG_PERSISTENT_BUILD_CACHE always creates a cache in the specified cache directory
c65b04999 fix(@​angular-devkit/build-angular): fail browser build when index generation fails
3d71c63b3 fix(@​angular-devkit/build-angular): fix issue were @media all causing critical CSS inling to fail
9a04975a2 fix(@​angular-devkit/build-angular): extractLicenses didn't have an effect when using server builder
2ac8e9c0e fix(@​angular-devkit/build-angular): display incompatibility errors
2c2b49919 fix(@​angular-devkit/build-angular): limit advanced terser passes to two
1be3b0783 fix(@​angular-devkit/build-angular): exclude outputPath from persistent build cache key
fefd6d042 perf(@​angular-devkit/build-angular): use esbuild as a CSS optimizer for component styles
18cfa0431 feat(@​angular-devkit/build-angular): add support to inline Adobe Fonts
9a751f0f8 fix(@​angular-devkit/build-angular): handle ENOENT and ENOTDIR errors when deleting outputs
41e645792 fix(@​angular-devkit/build-angular): downlevel for await...of when targetting ES2018+
070a13364 fix(@​angular-devkit/build-angular): configure webpack target in common configuration
da32daa75 perf(@​angular-devkit/build-angular): use combination of esbuild and terser as a JavaScript optimizer
6a2b11906 perf(@​angular-devkit/build-angular): cache JavaScriptOptimizerPlugin results
ab17b1721 fix(@​angular-devkit/build-angular): handle ng-packagr errors more gracefully.
d4c5f8518 fix(@​angular-devkit/build-angular): control linker template sourcemapping via builder sourcemap options
06181c2fb fix(@​angular-devkit/build-angular): parse web-workers in tests when webWorkerTsConfig is defined
@​angular-devkit/build-webpack
Commit Description
615353022 fix(@​angular-devkit/build-webpack): emit result when webpack is closed
@​ngtools/webpack
Commit Description
dbbcf5c8c fix(@​ngtools/webpack): only track file dependencies
7536338e0 fix(@​ngtools/webpack): allow generated assets of Angular component resources
720feee34 fix(@​ngtools/webpack): avoid non-actionable template type-checker syntax diagnostics
6a7bcf330 fix(@​ngtools/webpack): encode component style data
12c14b565 fix(@​ngtools/webpack): remove no longer needed component styles workaround
@​schematics/angular
Commit Description
20fd33f6d feat(@​schematics/angular): destroy test module after every test
5b10d4f54 fix(@​schematics/angular): remove unsafe any usage in application spec file
1b5e18e7b fix(@​schematics/angular): replace interactive div with button in application component template
0907b6941 fix(@​schematics/angular): use stricter semver for karma-jasmine-html-reporter
8ad1539c5 fix(@​schematics/angular): add 'none' value for the 'style' option of the component schematic
e5ba29c7d fix(@​schematics/angular): display warning during migrations when using third-party builders
a44dc02fe fix(@​schematics/angular): add devtools to ng new

Special Thanks:

Alan Agius, Charles Lyding, David Scourfield, Doug Parker, hien-pham, Joey Perrott, LeonEck, Mike
Jancar, twerske, Vaibhav Singh and originalfrostig

v12.1.4

Compare Source

@​angular/cli
Commit Description
e02c97dd0 fix(@​angular/cli): merge npmrc files values
@​schematics/angular
Commit Description
cfc267426 fix(@​schematics/angular): ensure valid SemVer range for new project Angular packages
@​angular-devkit/build-angular
Commit Description
55c0bddc8 fix(@​angular-devkit/build-angular): add priority to copy-webpack-plugin patterns
@​angular-devkit/build-webpack
Commit Description
b3736a3c0 fix(@​angular-devkit/build-webpack): emit result when webpack is closed

Special Thanks:

Alan Agius, Charles Lyding, Joey Perrott and originalfrostig

v12.1.3

Compare Source

@​angular/cli
Commit Description
eaa2378b6 fix(@​angular/cli): handle YARN_ environment variables during ng update and ng add
4b9a41bde fix(@​angular/cli): handle NPM_CONFIG environment variables during ng update and ng add
@​angular-devkit/build-angular
Commit Description
04e9ffe4f fix(@​angular-devkit/build-angular): allow classes with pure annotated static properties to be optimized
6ae17e265 fix(@​angular-devkit/build-angular): dasherize disable-host-check suggestion

Special Thanks:

Alan Agius, Charles Lyding, Joey Perrott, LeonEck and Mike Jancar

v12.1.2

Compare Source

angular/angular

v12.2.7

Compare Source

common
Commit Type Description
2bb4bf1468 fix titlecase pipe incorrectly handling numbers (#​43476)
compiler
Commit Type Description
9c8a1f8a71 fix include leading whitespace in source-spans of i18n messages (#​43132)
compiler-cli
Commit Type Description
defb02f11e fix handle directives that refer to a namespaced class in a type parameter bound (#​43511)
platform-browser
Commit Type Description
adc7c56ede fix improve error message for missing animation trigger (#​41356)

Special Thanks

Andrew Scott, Daniel Díaz, George Kalpakas, JoostK, Kristiyan Kostadinov, Mwiku, Pete Bacon Darwin, Teri Glover, Virginia Dooley, Xiaohanxu1996, dario-piotrowicz and kirjs

v12.2.6

Compare Source

animations
Commit Type Description
141fde1632 fix emit pure annotations to static property initializers (#​43344)
core
Commit Type Description
ca510c87c5 fix emit pure annotations to static property initializers (#​43344)
router
Commit Type Description
4034f252c9 fix Allow renavigating to failed URLs (#​43424)
service-worker
Commit Type Description
a102b27641 fix clear service worker cache in safety worker (#​43324)

Special Thanks

Alan Agius, Amadou Sall, Andrew Kushnir, Andrew Scott, Aristeidis Bampakos, Bjarki, David Shevitz, George Kalpakas, Joe Martin (Crowdstaffing), Michele Stieven, Naveed Ahmed, dario-piotrowicz, mezhik91 and mgechev

v12.2.5

Compare Source

router
Commit Description
a0bd6e90f9 fix: add more context to Unhandled Navigation Error (#​43291)

Special Thanks:

Alan Agius, Charles Barnes, Enea Jahollari, George Kalpakas, Ikko Ashimine, Paul Gschwendtner, Pete Bacon Darwin, William Sedlacek and dario-piotrowicz

v12.2.4

Compare Source

compiler-cli
Commit Description
8233906be2 fix: Emit type annotations for synthesized decorator fields (#​43021)

Special Thanks:

Andrew Scott, Daniel Trevino, George Kalpakas, Joey Perrott, Kristiyan Kostadinov, nickreid and segunb

v12.2.3

Compare Source

service-worker
Commit Description
fc7f92159d fix: NPE if onActionClick is undefined (#​43210)

Special Thanks:

Daniel Trevino, Erik Slack, George Kalpakas, dario-piotrowicz and shlasouski

v12.2.2

Compare Source

animations
Commit Description
bb6555979d fix: add pure annotations to static property initializers (#​43064)
core
Commit Description
738b23347e fix: add pure annotations to static property initializers (#​43064)
platform-browser
Commit Description
535837e617 perf: avoid intermediate arrays in server transition (#​43145)
router
Commit Description
6449590ec8 fix: eagerly update internal state on browser-triggered navigations (#​43102)

Special Thanks:

Andrew Scott, Aristeidis Bampakos, Charles Lyding, Edoardo Dusi, George Kalpakas, Joe Martin (Crowdstaffing), Joey Perrott, Kirk Larkin, Kristiyan Kostadinov, Pete Bacon Darwin, TIffany Davis, Theoklitos Bampouris, ali, dario-piotrowicz and pichuser

v12.2.1

Compare Source

router
Commit Description
dd3abdb9d9 fix(router): ensure check for match options is compatible with property renaming (#​43086)

Special Thanks:

Amadou Sall, Andrew Kushnir, Andrew Scott, Daniel Trevino, Erik Slack, Fabien BERNARD, George Kalpakas, Jeroen van Warmerdam, Joey Perrott, Tim Gates and Vugar_Abdullayev

v12.2.0

Compare Source

core
Commit Description
bd7f0d8b70 fix(core): incorrect error reported when trying to re-create view which had an error during creation (#​43005)
language-service
Commit Description
aace1e71d8 fix(language-service): global autocomplete doesn't work when the user tries to modify the symbol (#​42923)

Special Thanks:

Alex Rickabaugh, Joe Martin, Joey Perrott, Kristiyan Kostadinov, Nichola Alkhouri, Paul Gschwendtner, Pete Bacon Darwin, atscott, dario-piotrowicz and ivanwonder

v12.1.5

Compare Source

This release contains various API docs improvements.

v12.1.4

Compare Source

compiler-cli
Commit Description
77ae4459d3 fix(compiler-cli): use correct module resolution context for absolute imports in .d.ts files (#​42879)
f589b01672 perf(compiler-cli): skip analysis in incremental builds for files without Angular behavior (#​42562)
core
Commit Description
a779a1029b fix(core): correctly handle null or undefined in ErrorHandler#handleError() (#​42881)

Special Thanks:

Andrew Scott, Daniel Trevino, Dylan Hunn, George Kalpakas, Joey Perrott, JoostK, Paul Gschwendtner, Pete Bacon Darwin, Teri Glover, Vladyslav, Yuvaraj and codebriefcase

v12.1.3

Compare Source

animations
Commit Description
3cddc3d6bc fix(animations): normalize final styles in buildStyles (#​42763)
compiler-cli
Commit Description
d207ea06d1 fix(compiler-cli): use correct module import for types behind a forwardRef (#​42887)
e6d520f3d9 perf(compiler-cli): optimize cycle detection using a persistent cache (#​41271)
core
Commit Description
a6db152c78 fix(core): use correct injector when resolving DI tokens from within a directive provider factory (#​42886)

Special Thanks:

Alan Agius, David Shevitz, George Kalpakas, Joey Perrott, JoostK, Krzysztof Kotowicz, Minko Gechev, Paul Gschwendtner and dario-piotrowicz

v12.1.2

Compare Source

bazel
Commit Description
4a8ab4f149 fix(bazel): enable dts bundling for Ivy packages (#​42728)
common
Commit Description
d654c7933a fix(common): re-sort output of KeyValuePipe when compareFn changes (#​42821)
compiler
Commit Description
2566cbb48c fix(compiler): add mappings for all HTML entities (#​42818)
65330f03a9 fix(compiler): incorrect context object being referenced from listener instructions inside embedded views (#​42755)
compiler-cli
Commit Description
17d3de25da fix(compiler-cli): properly emit literal types when recreating type parameters in a different file (#​42761)
0a17e98ae2 fix(compiler-cli): inline type checking instructions no longer prevent incremental reuse (#​42759)
45116097c1 fix(compiler-cli): support reflecting namespace declarations (#​42728)
df5cc1fbbf fix(compiler-cli): return directives for an element on a microsyntax template (#​42640)
core
Commit Description
63013546e1 fix(core): associate the NgModule scope for an overridden component (#​42817)
9ebd41e39c fix(core): allow proper type inference when ngFor is used with a trackBy function (#​42692)
41c6877c01 fix(core): error in TestBed if module is reset mid-compilation in ViewEngine (#​42669)
language-service
Commit Description
[97c18f4](https://togithub.com/angular/angular/com

Configuration

📅 Schedule: "after 10pm every weekday,before 4am every weekday,every weekend" in timezone America/Tijuana.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added action: review The PR is still awaiting reviews from at least one requested reviewer area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release labels Jun 18, 2021
@google-cla google-cla bot added the cla: yes label Jun 18, 2021
@ngbot ngbot bot modified the milestone: Backlog Jun 18, 2021
@pullapprove pullapprove bot requested a review from gkalpak June 18, 2021 07:03
@gkalpak gkalpak self-assigned this Jun 18, 2021
@gkalpak
Copy link
Copy Markdown
Member

gkalpak commented Jun 18, 2021

The failure is caused by a bug in @angular-devkit/build-angular v12.0.5 introduced in angular/angular-cli@071c8d1. (More specifically, this line should be webWorkerTsConfig !== undefined.)

UPDATE: @alan-agius4 is working on a fix.

@gkalpak gkalpak removed their assignment Jun 18, 2021
@alan-agius4
Copy link
Copy Markdown
Contributor

Should be addressed via angular/angular-cli#21160

@renovate renovate bot force-pushed the renovate/angular branch 4 times, most recently from 033fd27 to aee22ec Compare June 25, 2021 07:53
@alan-agius4
Copy link
Copy Markdown
Contributor

@gkalpak looks like we need to update the payload sizes.

@gkalpak
Copy link
Copy Markdown
Member

gkalpak commented Jun 25, 2021

@alan-agius4, do we know what causes the size increase? (It seems to be coming from the CLI/devkit.)

@alan-agius4
Copy link
Copy Markdown
Contributor

The increase in runtime is likely caused by trusted types.

Regarding the size increase in main, I don’t know if it might be caused by the new version of build-optimizer, or something else.

Guess we need check the diffs.

@gkalpak
Copy link
Copy Markdown
Member

gkalpak commented Jun 25, 2021

👍 I'll dig into it.

@gkalpak gkalpak force-pushed the renovate/angular branch from aee22ec to 14d5274 Compare June 29, 2021 14:48
@google-cla

This comment has been minimized.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jun 29, 2021
Comment thread goldens/size-tracking/aio-payloads.json Outdated
"runtime-es2017": 4619,
"main-es2017": 456437,
"runtime-es2017": 4841,
"main-es2017": 458615,
Copy link
Copy Markdown
Member

@gkalpak gkalpak Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, from the ~2KB increase, ~0.5KB come from updating CLI/devkit and ~1.5KB from updating CDK.

@gkalpak

This comment has been minimized.

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 29, 2021
@gkalpak
Copy link
Copy Markdown
Member

gkalpak commented Jun 29, 2021

The remaining failures are:

  • integration/cli-hello-world-ivy-minimal/:
    • main-es2015: From 17597B to 27289B.
  • integration/cli-hello-world-lazy/:
    • runtime-es2015: From 2854B to 3076B.
    • main-es2015: From 296436B to 241453B.

@renovate renovate bot force-pushed the renovate/angular branch 10 times, most recently from 46f10c1 to 3913e5a Compare August 17, 2021 05:14
@alan-agius4
Copy link
Copy Markdown
Contributor

Still seeing some significant size increase in one test, even with @clydin change #43064

Skipped uploading data for 'cli-hello-world-ivy-minimal', because this is a pull request.
Verifying sizes against '/home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/bazel-out/k8-fastbuild/bin/integration/cli-hello-world-ivy-minimal_test.sh.runfiles/angular/goldens/size-tracking/integration-payloads.json'...
SUCCESS: Commit undefined uncompressed polyfills-es2015 did NOT cross size threshold of 500 bytes or >1% (expected: 37127, actual: 36941).
FAIL: Commit undefined uncompressed runtime-es2015 exceeded expected size by 500 bytes or >1% (expected: 1205, actual: 1228).
FAIL: Commit undefined uncompressed main-es2015 exceeded expected size by 500 bytes or >1% (expected: 17597, actual: 27815).
If this is a desired change, please update the size limits in file 'goldens/size-tracking/integration-payloads.json'.

@alan-agius4
Copy link
Copy Markdown
Contributor

I was thinking that we should replace https://github.com/angular/angular/blob/master/integration/side-effects/package.json to use the new more correct build-optimizer to help prevent merging of side effects.

@alan-agius4
Copy link
Copy Markdown
Contributor

Following further investigation it appears that the pure comments are not being emitted.
https://github.com/angular/core-builds/blob/42e385a116d19e7d828007e14fdb1598f0552ce7/esm2015/src/di/injector.js#L59-L60

This is caused by TypeScript which will not emit the PURE comment when downlevelling the static properties https://www.typescriptlang.org/play?ssl=3&ssc=2&pln=1&pc=1#code/KYDwDg9gTgLgBAQwEYGcZQQY3pgNglFOASQDsArYbaOAbwFgAoOONBGAS0zgDkBVADICAXCQpUYNALxwA9ACo4AAQD6KgAp8ASgFE1cebLilgAd14BXXLjKVqUABQBKANxMAvkA

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: build & ci Related the build and CI infrastructure of the project cla: yes target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants