Skip to content

docs: removed outdated migration documentation#46257

Closed
phalgunv wants to merge 1 commit intoangular:mainfrom
phalgunv:unclear-migration-doc
Closed

docs: removed outdated migration documentation#46257
phalgunv wants to merge 1 commit intoangular:mainfrom
phalgunv:unclear-migration-doc

Conversation

@phalgunv
Copy link
Copy Markdown
Contributor

@phalgunv phalgunv commented Jun 4, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

closes #46236

@pullapprove pullapprove bot requested review from dgp1130 and mgechev June 4, 2022 11:25
@phalgunv phalgunv changed the title docs : removed outdated migration documentation docs: removed outdated migration documentation Jun 4, 2022
@dgp1130 dgp1130 requested a review from alan-agius4 June 6, 2022 17:05
@dgp1130
Copy link
Copy Markdown
Contributor

dgp1130 commented Jun 6, 2022

I don't have much context on this, but the doc seems pretty old. @alan-agius4 is this still relevant or should we drop it?

Copy link
Copy Markdown
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alan-agius4 alan-agius4 added comp: docs target: patch This PR is targeted for the next patch release labels Jun 6, 2022
@ngbot ngbot bot added this to the Backlog milestone Jun 6, 2022
@alan-agius4
Copy link
Copy Markdown
Contributor

@dgp1130 we can definitely drop this.

@alan-agius4 alan-agius4 removed the request for review from mgechev June 6, 2022 17:11
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 6, 2022
Copy link
Copy Markdown
Contributor

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the confirmation @alan-agius4, and for taking the time to clean up the obsolete doc @phalgunv!

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 6, 2022
@phalgunv
Copy link
Copy Markdown
Contributor Author

phalgunv commented Jun 6, 2022

Thanks @dgp1130 and @alan-agius4 for approving my first PR! What would be the next steps?

@dgp1130
Copy link
Copy Markdown
Contributor

dgp1130 commented Jun 6, 2022

@phalgunv, we have a "caretaker" rotation that merges PRs which area ready. The action: merge label marks this as ready to merge, so the caretaker should merge it today or tomorrow. Nothing you need to do. :D

@alxhub
Copy link
Copy Markdown
Member

alxhub commented Jun 6, 2022

This PR was merged into the repository by commit 385b5ec.

alxhub pushed a commit that referenced this pull request Jun 6, 2022
@alxhub alxhub closed this in 385b5ec Jun 6, 2022
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migration guide unclear on steps

5 participants