build(bazel): prevent remote cache misses on dgeni build #48585
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using 'always' as the stamp attribute caused stable-status.txt to always be included as an input, which has different values on different ci executors causing a cache miss. We run the regular aio build without stamping on ci so only include status files when stamping is explicitly enabled.
angular-robot
bot
added
the
area: build & ci
kormide
commented
Dec 23, 2022
| exec_properties = ENABLE_NETWORK, | ||
| output_dir = True, | ||
| stamp = "@rules_nodejs//nodejs/stamp:always", | ||
| stamp = "@rules_nodejs//nodejs/stamp:use_stamp_flag", |
There was a problem hiding this comment.
This is actually the default, but I like to keep this here to indicate that this action makes use of stamping.
devversion
approved these changes
Dec 23, 2022
devversion
added
the
target: patch
|
This PR was merged into the repository by commit 8c9f067. |
devversion
pushed a commit
that referenced
this pull request
Dec 24, 2022
Using 'always' as the stamp attribute caused stable-status.txt to always be included as an input, which has different values on different ci executors causing a cache miss. We run the regular aio build without stamping on ci so only include status files when stamping is explicitly enabled. PR Close #48585
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
Using 'always' as the stamp attribute caused stable-status.txt to always be included as an input, which has different values on different ci executors causing a cache miss. We run the regular aio build without stamping on ci so only include status files when stamping is explicitly enabled. PR Close angular#48585
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
test_aiostep always has a cache miss on//aio:dgeni.Using 'always' as the stamp attribute caused stable-status.txt to always be included as an input, which has different values on different ci executors causing a cache miss.
We run the regular aio build without stamping on ci so only include status files when stamping is explicitly enabled.
What is the new behavior?
Cache hit on ci. Note that this does not fix the caching issues for the
test_aio_localstep which must enable stamping for architect to work with local angular packages. I will look into those issues separately.Does this PR introduce a breaking change?
Other information
Note that even when there is a cache hit you will often see dgeni output in the ci logs. This is because Bazel also caches stdout and seeing this output does not indicate that dgeni is re-running. Outputting the json execution log confirms the cache hit.