Skip to content

Conversation

@davidlj95
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Wrong function name in recently introduced provideEnvironmentInitializer function

Issue Number: N/A

What is the new behavior?

Use the proper function name

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from AndrewKushnir October 25, 2024 10:31
@angular-robot angular-robot bot added the area: docs Related to the documentation label Oct 25, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 25, 2024
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidlj95 thanks for improving Angular docs!

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate labels Oct 25, 2024
@AndrewKushnir
Copy link
Contributor

Caretaker note: no presubmit required, docs-only change.

@alxhub
Copy link
Member

alxhub commented Oct 28, 2024

This PR was merged into the repository by commit 317d704.

The changes were merged into the following branches: main, 19.0.x

@alxhub alxhub closed this in 317d704 Oct 28, 2024
@davidlj95 davidlj95 deleted the docs-provide-environment-initializer branch October 28, 2024 20:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants