-
Notifications
You must be signed in to change notification settings - Fork 26.9k
fix(code size): revert previous devMode change to restore size targets #5896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/cc @vsavkin @IgorMinar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't change limits in a drive-by way. in the future please create separate commit and explain why you are decreasing the limit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
I believe that I saw some tests in g3 that required dev mode even when not running in dartium's checked mode. can you please verify how to deal with this (by cs-ing enableDevMode) before we merge this in? |
This is inconsistent with TS/JS, but if set to true dart2js tree-shaking doesn't work and our e2e tests time out. Related to angular#5896
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
9422eb4 to
75b20ff
Compare
This commit reverts a8d9dbf that introduced a code size regression (16kb gzipped, 63kb minified) in Dart. Effect on the hello world app: gzipped: 105kb -> 89kb minified: 370kb -> 317kb BREAKING CHANGE: - This is very unlikely to be breaking, but I'm still marking just in case. The only change to the user should be that dev mode is driven by Dart's checked mode, like it was in the past.
Our code size SLA is 100kb gzipped and 300kb minified. Our target is 10kb gzipped. We are currently under 90kb gzipped. Let's keep it that way while looking for ways to improve the situation further. We're not <300kb minified yet, so we should be stricter here too.
|
CLAs look good, thanks! |
|
Merging PR #5896 on behalf of @alexeagle to branch presubmit-alexeagle-pr-5896. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit reverts a8d9dbf that introduced a code size regression (16kb gzipped, 63kb minified) in Dart.
Effect on the hello world app:
gzipped: 105kb -> 89kb
minified: 370kb -> 317kb
BREAKING CHANGE:
Closes #5883
Closes #5888