Allow EnvironmentProviders in HttpFeature for Custom HTTP Client Features #59969
Conversation
| }; | ||
| } | ||
|
|
||
| export function provideHttpClient( |
There was a problem hiding this comment.
any change to provideHttpClient should be done in packages/common/http/src/provider.ts where it's located.
| ): EnvironmentProviders { | ||
| return makeEnvironmentProviders( | ||
| features.flatMap((f) => | ||
| f.ɵproviders.map((provider) => |
There was a problem hiding this comment.
this breaks existing providers
| const result = provideHttpClient(customFeature); | ||
|
|
||
| expect(result).toBeDefined(); | ||
| expect(result).toEqual(jasmine.any(Object)); |
There was a problem hiding this comment.
This doesn't test that the providers works correctly.
thePunderWoman
added
the
area: common
This is an intended design choice, features are not open-ended and therefore not designed to be extended. I'm closing this PR for now; any discussion can happen in #59670. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
PR Checklist:
Please check if your PR fulfills the following requirements:
PR Type:
What kind of change does this PR introduce?
PR Description:
Right now,
HttpFeatureonly acceptsProvider[], which makes it harder to extend the HTTP client with custom features. This change lets it also acceptEnvironmentProviders, making it easier to customize things like interceptors or backend replacements.provideHttpClient()already converts providers toEnvironmentProviders, so this just makes the API more consistent. 🚀