Skip to content

docs: remove todo from jsdoc #60042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thePunderWoman wants to merge 1 commit into from
+1 −4
Closed

docs: remove todo from jsdoc #60042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/forms/src/model/abstract_model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,8 +759,6 @@ export abstract class AbstractControl<TValue = any, TRawValue extends TValue = T
* accessing a value of a parent control (using the `value` property) from the callback of this
* event might result in getting a value that has not been updated yet. Subscribe to the
* `valueChanges` event of the parent control instead.
*
* TODO: this should be piped from events() but is breaking in G3
*/
public readonly valueChanges!: Observable<TValue>;

Expand All @@ -770,8 +768,6 @@ export abstract class AbstractControl<TValue = any, TRawValue extends TValue = T
*
* @see {@link FormControlStatus}
* @see {@link AbstractControl.status}
*
* TODO: this should be piped from events() but is breaking in G3
Comment thread
thePunderWoman marked this conversation as resolved.
Outdated
*/
public readonly statusChanges!: Observable<FormControlStatus>;

Expand Down Expand Up @@ -1626,6 +1622,7 @@ export abstract class AbstractControl<TValue = any, TRawValue extends TValue = T

/** @internal */
_initObservables() {
// TODO: this should be piped from events() but is breaking in G3
(this as Writable<this>).valueChanges = new EventEmitter();
(this as Writable<this>).statusChanges = new EventEmitter();
}
Expand Down