refactor(core): inline standalone check to be dropped

[arturovt]

Inlines standalone check into the message to be dropped.

[JeanMeche]

Isn't that due to isStandalone not being marked as pure ? We should probably fix the root cause of that.

[arturovt]

No, it's because ESBuild conservatively assumes that you might still access the variable by name somehow, either by running the code in a global scope or by appending more code to esbuild’s output.

[JeanMeche]

Right, it's related to evanw/esbuild#639.

[JeanMeche]

For the sake of readability wdyt of

      let errorMessage = '';
      if (typeof ngDevMode === 'undefined' || ngDevMode) {
        const standalone = !isComponentFactory && isStandalone(componentOrFactory);
        errorMessage =
          'Cannot bootstrap as there are still asynchronous initializers running.' +
          (standalone
            ? ''
            : ' Bootstrap components in the `ngDoBootstrap` method of the root module.');
      }
      throw new RuntimeError(RuntimeErrorCode.ASYNC_INITIALIZERS_STILL_RUNNING, errorMessage);

[arturovt]

Updated.

[AndrewKushnir]

This PR was merged into the repository by commit 526268c.

The changes were merged into the following branches: main, 19.2.x

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}