chore: remove node.d.tsd from manual typings#6035
Closed
wesleycho wants to merge 1 commit intoangular:masterfrom
Closed
chore: remove node.d.tsd from manual typings#6035wesleycho wants to merge 1 commit intoangular:masterfrom
wesleycho wants to merge 1 commit intoangular:masterfrom
Conversation
- Removes node.d.tsd from manual typing due to problems is causes in any project using any type definition files that have node/node.d.tsd as a dependency
wesleycho
force-pushed
the
chore/remove-node-tsd
branch
from
47b465b to
de3655e
Compare
Contributor
|
This PR is stale (does not rebase; pass CI; had no activity for a while). It is probably our fault, and we are sorry. In an effort to keep our PR queue under control, and prevent us from taking too long to get back to you we are cleaning up the queue. Unfortunately this means that this PR is getting closed. If you would like to resurrect this change, please rebase on master, make the tests pass and create a new PR. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main driver for this is that it is causing duplicate identifier errors in TypeScript in angular/universal on compilation - see angular/universal#150 .