refactor(platform-server): expose internal render method for extensibility
#60416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibility The `renderApplication` and `renderModule` methods currently encapsulate the entire rendering process, making it difficult to intercept key phases from a non-Angular context. This change exports the internal `render` method, allowing us to perform operations such as: - Flushing headers before hydration preparation - Handling non static redirects (e.g., 302 responses) - Intercepting router events for additional processing This refactor serves as an experimental step toward improving the API for better customization and integration in the future.
alan-agius4
added
the
target: patch
hybrist
approved these changes
Mar 17, 2025
Contributor
hybrist
left a comment
hybrist
left a comment
There was a problem hiding this comment.
That looks like a nice level of abstraction for exploration (and +1 on marking it as private API)! Thanks for the ping.
alan-agius4
added
the
action: review
AndrewKushnir
approved these changes
Mar 17, 2025
AndrewKushnir
removed
the
action: review
alan-agius4
added
action: review
Member
|
This PR was merged into the repository by commit bf5d995. The changes were merged into the following branches: main, 19.2.x |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Mar 18, 2025
…ibility (#60416) The `renderApplication` and `renderModule` methods currently encapsulate the entire rendering process, making it difficult to intercept key phases from a non-Angular context. This change exports the internal `render` method, allowing us to perform operations such as: - Flushing headers before hydration preparation - Handling non static redirects (e.g., 302 responses) - Intercepting router events for additional processing This refactor serves as an experimental step toward improving the API for better customization and integration in the future. PR Close #60416
sod
reviewed
Apr 2, 2025
| * @param applicationRef - Reference to the Angular application. | ||
| * @returns A promise that resolves to the rendered string. | ||
| */ | ||
| export async function renderInternal( |
Contributor
There was a problem hiding this comment.
Thanks a lot 🙏 Even though this is private, this allows us to use incremental hydration without much hackery (as we also have a custom lifecycle on ssr)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
renderApplicationandrenderModulemethods currently encapsulate the entire rendering process, making it difficult to intercept key phases from a non-Angular context. This change exports the internalrendermethod, allowing us to perform operations such as:This refactor serves as an experimental step toward improving the API for better customization and integration in the future.
//cc @jkrems, I believe you might also find this useful.